Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: tw686x: switch from 'pci_' to 'dma_' API

The wrappers in include/linux/pci-dma-compat.h should go away.

The patch has been generated with the coccinelle script below and has been
hand modified to replace GFP_ with a correct flag.
It has been compile tested.

When memory is allocated in 'tw686x_audio_dma_alloc()' (tw686x-audio.c)
GFP_KERNEL can be used because it is only called from a probe function
and no spinlock is taken in the between.
The call chain is:
tw686x_probe (tw686x-core.c)
--> tw686x_audio_init (tw686x-audio.c)
--> tw686x_audio_dma_alloc (tw686x-audio.c)

When memory is allocated in 'tw686x_memcpy_dma_alloc()' and in
'tw686x_sg_dma_alloc()' (tw686x-video.c) GFP_KERNEL can be used because
these functions are .alloc functions from a tw686x_dma_ops structure.

@@
@@
- PCI_DMA_BIDIRECTIONAL
+ DMA_BIDIRECTIONAL

@@
@@
- PCI_DMA_TODEVICE
+ DMA_TO_DEVICE

@@
@@
- PCI_DMA_FROMDEVICE
+ DMA_FROM_DEVICE

@@
@@
- PCI_DMA_NONE
+ DMA_NONE

@@
expression e1, e2, e3;
@@
- pci_alloc_consistent(e1, e2, e3)
+ dma_alloc_coherent(&e1->dev, e2, e3, GFP_)

@@
expression e1, e2, e3;
@@
- pci_zalloc_consistent(e1, e2, e3)
+ dma_alloc_coherent(&e1->dev, e2, e3, GFP_)

@@
expression e1, e2, e3, e4;
@@
- pci_free_consistent(e1, e2, e3, e4)
+ dma_free_coherent(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_map_single(e1, e2, e3, e4)
+ dma_map_single(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_unmap_single(e1, e2, e3, e4)
+ dma_unmap_single(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4, e5;
@@
- pci_map_page(e1, e2, e3, e4, e5)
+ dma_map_page(&e1->dev, e2, e3, e4, e5)

@@
expression e1, e2, e3, e4;
@@
- pci_unmap_page(e1, e2, e3, e4)
+ dma_unmap_page(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_map_sg(e1, e2, e3, e4)
+ dma_map_sg(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_unmap_sg(e1, e2, e3, e4)
+ dma_unmap_sg(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_dma_sync_single_for_cpu(e1, e2, e3, e4)
+ dma_sync_single_for_cpu(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_dma_sync_single_for_device(e1, e2, e3, e4)
+ dma_sync_single_for_device(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_dma_sync_sg_for_cpu(e1, e2, e3, e4)
+ dma_sync_sg_for_cpu(&e1->dev, e2, e3, e4)

@@
expression e1, e2, e3, e4;
@@
- pci_dma_sync_sg_for_device(e1, e2, e3, e4)
+ dma_sync_sg_for_device(&e1->dev, e2, e3, e4)

@@
expression e1, e2;
@@
- pci_dma_mapping_error(e1, e2)
+ dma_mapping_error(&e1->dev, e2)

@@
expression e1, e2;
@@
- pci_set_dma_mask(e1, e2)
+ dma_set_mask(&e1->dev, e2)

@@
expression e1, e2;
@@
- pci_set_consistent_dma_mask(e1, e2)
+ dma_set_coherent_mask(&e1->dev, e2)

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

authored by

Christophe JAILLET and committed by
Mauro Carvalho Chehab
c1dbcf62 7a77379f

+16 -16
+7 -6
drivers/media/pci/tw686x/tw686x-audio.c
··· 300 300 for (pb = 0; pb < 2; pb++) { 301 301 if (!ac->dma_descs[pb].virt) 302 302 continue; 303 - pci_free_consistent(dev->pci_dev, ac->dma_descs[pb].size, 304 - ac->dma_descs[pb].virt, 305 - ac->dma_descs[pb].phys); 303 + dma_free_coherent(&dev->pci_dev->dev, ac->dma_descs[pb].size, 304 + ac->dma_descs[pb].virt, 305 + ac->dma_descs[pb].phys); 306 306 ac->dma_descs[pb].virt = NULL; 307 307 } 308 308 } ··· 313 313 int pb; 314 314 315 315 /* 316 - * In the memcpy DMA mode we allocate a consistent buffer 316 + * In the memcpy DMA mode we allocate a coherent buffer 317 317 * and use it for the DMA capture. Otherwise, DMA 318 318 * acts on the ALSA buffers as received in pcm_prepare. 319 319 */ ··· 324 324 u32 reg = pb ? ADMA_B_ADDR[ac->ch] : ADMA_P_ADDR[ac->ch]; 325 325 void *virt; 326 326 327 - virt = pci_alloc_consistent(dev->pci_dev, AUDIO_DMA_SIZE_MAX, 328 - &ac->dma_descs[pb].phys); 327 + virt = dma_alloc_coherent(&dev->pci_dev->dev, 328 + AUDIO_DMA_SIZE_MAX, 329 + &ac->dma_descs[pb].phys, GFP_KERNEL); 329 330 if (!virt) { 330 331 dev_err(&dev->pci_dev->dev, 331 332 "dma%d: unable to allocate audio DMA %s-buffer\n",
+1 -1
drivers/media/pci/tw686x/tw686x-core.c
··· 276 276 } 277 277 278 278 pci_set_master(pci_dev); 279 - err = pci_set_dma_mask(pci_dev, DMA_BIT_MASK(32)); 279 + err = dma_set_mask(&pci_dev->dev, DMA_BIT_MASK(32)); 280 280 if (err) { 281 281 dev_err(&pci_dev->dev, "32-bit PCI DMA not supported\n"); 282 282 err = -EIO;
+8 -9
drivers/media/pci/tw686x/tw686x-video.c
··· 92 92 } 93 93 94 94 if (desc->virt) { 95 - pci_free_consistent(dev->pci_dev, desc->size, 96 - desc->virt, desc->phys); 95 + dma_free_coherent(&dev->pci_dev->dev, desc->size, desc->virt, 96 + desc->phys); 97 97 desc->virt = NULL; 98 98 } 99 99 } ··· 110 110 "Allocating buffer but previous still here\n"); 111 111 112 112 len = (vc->width * vc->height * vc->format->depth) >> 3; 113 - virt = pci_alloc_consistent(dev->pci_dev, len, 114 - &vc->dma_descs[pb].phys); 113 + virt = dma_alloc_coherent(&dev->pci_dev->dev, len, 114 + &vc->dma_descs[pb].phys, GFP_KERNEL); 115 115 if (!virt) { 116 116 v4l2_err(&dev->v4l2_dev, 117 117 "dma%d: unable to allocate %s-buffer\n", ··· 258 258 struct tw686x_dev *dev = vc->dev; 259 259 260 260 if (desc->size) { 261 - pci_free_consistent(dev->pci_dev, desc->size, 262 - desc->virt, desc->phys); 261 + dma_free_coherent(&dev->pci_dev->dev, desc->size, desc->virt, 262 + desc->phys); 263 263 desc->virt = NULL; 264 264 } 265 265 ··· 276 276 void *virt; 277 277 278 278 if (desc->size) { 279 - 280 - virt = pci_alloc_consistent(dev->pci_dev, desc->size, 281 - &desc->phys); 279 + virt = dma_alloc_coherent(&dev->pci_dev->dev, desc->size, 280 + &desc->phys, GFP_KERNEL); 282 281 if (!virt) { 283 282 v4l2_err(&dev->v4l2_dev, 284 283 "dma%d: unable to allocate %s-buffer\n",