Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ceph: properly release page upon error

When ceph_update_writeable_page fails (including -EAGAIN), it
unlocks (w/ unlock_page) the page but does not 'release'
(w/ page_cache_release) properly.

Upon error, properly set *pagep to NULL, indicating an error.

Signed-off-by: Taesoo Kim <tsgatesv@gmail.com>
Signed-off-by: Yan, Zheng <zyan@redhat.com>

authored by

Taesoo Kim and committed by
Ilya Dryomov
c1d00b2d 1fe48023

+4
+4
fs/ceph/addr.c
··· 1146 1146 inode, page, (int)pos, (int)len); 1147 1147 1148 1148 r = ceph_update_writeable_page(file, pos, len, page); 1149 + if (r < 0) 1150 + page_cache_release(page); 1151 + else 1152 + *pagep = page; 1149 1153 } while (r == -EAGAIN); 1150 1154 1151 1155 return r;