Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: intel/ipu6: fix the buffer flags caused by wrong parentheses

The buffer flags is set by wrong due to wrong parentheses, the
FL_INCOMING flag is never taken an account.
Fix it by wrapping the ternary conditional operation with parentheses.

Fixes: 3c1dfb5a69cf ("media: intel/ipu6: input system video nodes and buffer queues")
Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

authored by

Bingbu Cao and committed by
Hans Verkuil
c19fa08c ab0ed481

+3 -3
+3 -3
drivers/media/pci/intel/ipu6/ipu6-isys-queue.c
··· 301 301 out_requeue: 302 302 if (bl && bl->nbufs) 303 303 ipu6_isys_buffer_list_queue(bl, 304 - (IPU6_ISYS_BUFFER_LIST_FL_INCOMING | 305 - error) ? 304 + IPU6_ISYS_BUFFER_LIST_FL_INCOMING | 305 + (error ? 306 306 IPU6_ISYS_BUFFER_LIST_FL_SET_STATE : 307 - 0, error ? VB2_BUF_STATE_ERROR : 307 + 0), error ? VB2_BUF_STATE_ERROR : 308 308 VB2_BUF_STATE_QUEUED); 309 309 flush_firmware_streamon_fail(stream); 310 310