Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

amd-xgbe: avoid misleading per-packet error log

On the receive path, packet can be damaged because of buffer
overflow in Rx FIFO. Avoid misleading per-packet error log when
packet->errors is set, this can flood the log. Instead, rely on the
standard rtnl_link_stats64 stats.

Fixes: c5aa9e3b8156 ("amd-xgbe: Initial AMD 10GbE platform driver")
Signed-off-by: Raju Rangoju <Raju.Rangoju@amd.com>
Link: https://patch.msgid.link/20260114163037.2062606-1-Raju.Rangoju@amd.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Raju Rangoju and committed by
Jakub Kicinski
c158f985 d998b0e5

+1 -4
+1 -4
drivers/net/ethernet/amd/xgbe/xgbe-drv.c
··· 1837 1837 s->multicast = pstats->rxmulticastframes_g; 1838 1838 s->rx_length_errors = pstats->rxlengtherror; 1839 1839 s->rx_crc_errors = pstats->rxcrcerror; 1840 - s->rx_fifo_errors = pstats->rxfifooverflow; 1840 + s->rx_over_errors = pstats->rxfifooverflow; 1841 1841 1842 1842 s->tx_packets = pstats->txframecount_gb; 1843 1843 s->tx_bytes = pstats->txoctetcount_gb; ··· 2292 2292 goto read_again; 2293 2293 2294 2294 if (error || packet->errors) { 2295 - if (packet->errors) 2296 - netif_err(pdata, rx_err, netdev, 2297 - "error in received packet\n"); 2298 2295 dev_kfree_skb(skb); 2299 2296 goto next_packet; 2300 2297 }