Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

clk: hisilicon: fix warning from smatch

drivers/clk/hisilicon/clk-hi3620.c:338
mmc_clk_delay() warn: always true condition '(para >= 0) => (0-u32max >= 0)'

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
Signed-off-by: Mike Turquette <mturquette@linaro.org>

authored by

Zhangfei Gao and committed by
Mike Turquette
c115b13b a665962e

+7 -8
+7 -8
drivers/clk/hisilicon/clk-hi3620.c
··· 326 326 { 327 327 u32 i; 328 328 329 - if (para >= 0) { 330 - for (i = 0; i < len; i++) { 331 - if (para % 2) 332 - val |= 1 << (off + i); 333 - else 334 - val &= ~(1 << (off + i)); 335 - para = para >> 1; 336 - } 329 + for (i = 0; i < len; i++) { 330 + if (para % 2) 331 + val |= 1 << (off + i); 332 + else 333 + val &= ~(1 << (off + i)); 334 + para = para >> 1; 337 335 } 336 + 338 337 return val; 339 338 } 340 339