ALSA: Use fallthrough pseudo-keyword · tjh.dev/kernel@c0dbbda

tjh.dev / kernel

fork atom

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

fork atom

ALSA: Use fallthrough pseudo-keyword

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20200708203236.GA5112@embeddedor
Signed-off-by: Takashi Iwai <tiwai@suse.de>

authored by

Gustavo A. R. Silva and committed by

Takashi Iwai 5 years ago c0dbbdad a0b224b9

+78 -80

35 changed files

expand all collapse all

sound

atmel

ac97c.c

core

memalloc.c

oss

pcm_oss.c

pcm_plugin.c

pcm_native.c

seq

oss

seq_oss_timer.c

seq_midi_emul.c

drivers

opl3

opl3_midi.c

isa

galaxy

galaxy.c

msnd

msnd_pinnacle_mixer.c

opti9xx

miro.c

opti92x-ad1848.c

sb8_main.c

oss

dmasound

dmasound_atari.c

dmasound_core.c

pci

ac97

ac97_codec.c

atiixp.c

azt3328.c

echoaudio

echoaudio.c

emu10k1

emupcm.c

hda

hda_beep.c

patch_conexant.c

patch_realtek.c

ice1712

delta.c

intel8x0.c

mixart

mixart.c

mixart_core.c

nm256

nm256.c

ymfpci

ymfpci_main.c

pcmcia

pdaudiocf

pdaudiocf_pcm.c

sparc

dbri.c

usb

card.c

clock.c

pcm.c

stream.c

+8 -8

sound/atmel/ac97c.c

reviewed

··· 356 356 camr = ac97c_readl(chip, CAMR); 357 357 358 358 switch (cmd) { 359 359 - case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: /* fall through */ 360 360 - case SNDRV_PCM_TRIGGER_RESUME: /* fall through */ 359 359 + case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: 360 360 + case SNDRV_PCM_TRIGGER_RESUME: 361 361 case SNDRV_PCM_TRIGGER_START: 362 362 ptcr = ATMEL_PDC_TXTEN; 363 363 camr |= AC97C_CMR_CENA | AC97C_CSR_ENDTX; 364 364 break; 365 365 - case SNDRV_PCM_TRIGGER_PAUSE_PUSH: /* fall through */ 366 366 - case SNDRV_PCM_TRIGGER_SUSPEND: /* fall through */ 365 365 + case SNDRV_PCM_TRIGGER_PAUSE_PUSH: 366 366 + case SNDRV_PCM_TRIGGER_SUSPEND: 367 367 case SNDRV_PCM_TRIGGER_STOP: 368 368 ptcr |= ATMEL_PDC_TXTDIS; 369 369 if (chip->opened <= 1) ··· 388 388 ptcr = readl(chip->regs + ATMEL_PDC_PTSR); 389 389 390 390 switch (cmd) { 391 391 - case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: /* fall through */ 392 392 - case SNDRV_PCM_TRIGGER_RESUME: /* fall through */ 391 391 + case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: 392 392 + case SNDRV_PCM_TRIGGER_RESUME: 393 393 case SNDRV_PCM_TRIGGER_START: 394 394 ptcr = ATMEL_PDC_RXTEN; 395 395 camr |= AC97C_CMR_CENA | AC97C_CSR_ENDRX; 396 396 break; 397 397 - case SNDRV_PCM_TRIGGER_PAUSE_PUSH: /* fall through */ 398 398 - case SNDRV_PCM_TRIGGER_SUSPEND: /* fall through */ 397 397 + case SNDRV_PCM_TRIGGER_PAUSE_PUSH: 398 398 + case SNDRV_PCM_TRIGGER_SUSPEND: 399 399 case SNDRV_PCM_TRIGGER_STOP: 400 400 ptcr |= ATMEL_PDC_RXTDIS; 401 401 if (chip->opened <= 1)

+1 -1

sound/core/memalloc.c

reviewed

··· 158 158 */ 159 159 dmab->dev.type = SNDRV_DMA_TYPE_DEV; 160 160 #endif /* CONFIG_GENERIC_ALLOCATOR */ 161 161 - /* fall through */ 161 161 + fallthrough; 162 162 case SNDRV_DMA_TYPE_DEV: 163 163 case SNDRV_DMA_TYPE_DEV_UC: 164 164 snd_malloc_dev_pages(dmab, size);

+1 -1

sound/core/oss/pcm_oss.c

reviewed

··· 2851 2851 substream = pcm_oss_file->streams[SNDRV_PCM_STREAM_PLAYBACK]; 2852 2852 if (substream) 2853 2853 break; 2854 2854 - /* Fall through */ 2854 2854 + fallthrough; 2855 2855 case VM_READ: 2856 2856 substream = pcm_oss_file->streams[SNDRV_PCM_STREAM_CAPTURE]; 2857 2857 break;

+1 -1

sound/core/oss/pcm_plugin.c

reviewed

··· 357 357 if (snd_mask_test(format_mask, (__force int)format1)) 358 358 return format1; 359 359 } 360 360 - /* fall through */ 360 360 + fallthrough; 361 361 default: 362 362 return (__force snd_pcm_format_t)-EINVAL; 363 363 }

+4 -4

sound/core/pcm_native.c

reviewed

··· 1903 1903 switch (substream->runtime->status->state) { 1904 1904 case SNDRV_PCM_STATE_PAUSED: 1905 1905 snd_pcm_pause(substream, false); 1906 1906 - /* fallthru */ 1906 1906 + fallthrough; 1907 1907 case SNDRV_PCM_STATE_SUSPENDED: 1908 1908 snd_pcm_stop(substream, SNDRV_PCM_STATE_SETUP); 1909 1909 break; ··· 2811 2811 case SNDRV_PCM_STATE_DRAINING: 2812 2812 if (substream->stream == SNDRV_PCM_STREAM_CAPTURE) 2813 2813 return -EBADFD; 2814 2814 - /* Fall through */ 2814 2814 + fallthrough; 2815 2815 case SNDRV_PCM_STATE_RUNNING: 2816 2816 return snd_pcm_update_hw_ptr(substream); 2817 2817 case SNDRV_PCM_STATE_PREPARED: ··· 3814 3814 case SNDRV_PCM_MMAP_OFFSET_STATUS_OLD: 3815 3815 if (pcm_file->no_compat_mmap || !IS_ENABLED(CONFIG_64BIT)) 3816 3816 return -ENXIO; 3817 3817 - /* fallthrough */ 3817 3817 + fallthrough; 3818 3818 case SNDRV_PCM_MMAP_OFFSET_STATUS_NEW: 3819 3819 if (!pcm_status_mmap_allowed(pcm_file)) 3820 3820 return -ENXIO; ··· 3822 3822 case SNDRV_PCM_MMAP_OFFSET_CONTROL_OLD: 3823 3823 if (pcm_file->no_compat_mmap || !IS_ENABLED(CONFIG_64BIT)) 3824 3824 return -ENXIO; 3825 3825 - /* fallthrough */ 3825 3825 + fallthrough; 3826 3826 case SNDRV_PCM_MMAP_OFFSET_CONTROL_NEW: 3827 3827 if (!pcm_control_mmap_allowed(pcm_file)) 3828 3828 return -ENXIO;

+1 -1

sound/core/seq/oss/seq_oss_timer.c

reviewed

··· 79 79 case TMR_WAIT_REL: 80 80 parm += rec->cur_tick; 81 81 rec->realtime = 0; 82 82 - /* fall through */ 82 82 + fallthrough; 83 83 case TMR_WAIT_ABS: 84 84 if (parm == 0) { 85 85 rec->realtime = 1;

+1 -1

sound/core/seq/seq_midi_emul.c

reviewed

··· 309 309 break; 310 310 case MIDI_CTL_MSB_DATA_ENTRY: 311 311 chan->control[MIDI_CTL_LSB_DATA_ENTRY] = 0; 312 312 - /* fall through */ 312 312 + fallthrough; 313 313 case MIDI_CTL_LSB_DATA_ENTRY: 314 314 if (chan->param_type == SNDRV_MIDI_PARAM_TYPE_REGISTERED) 315 315 rpn(ops, drv, chan, chset);

+2 -2

sound/drivers/opl3/opl3_midi.c

reviewed

··· 354 354 instr_4op = 1; 355 355 break; 356 356 } 357 357 - /* fall through */ 357 357 + fallthrough; 358 358 default: 359 359 spin_unlock_irqrestore(&opl3->voice_lock, flags); 360 360 return; ··· 443 443 switch (connection) { 444 444 case 0x03: 445 445 snd_opl3_calc_volume(&vol_op[2], vel, chan); 446 446 - /* fallthru */ 446 446 + fallthrough; 447 447 case 0x02: 448 448 snd_opl3_calc_volume(&vol_op[0], vel, chan); 449 449 break;

+3 -3

sound/isa/galaxy/galaxy.c

reviewed

··· 247 247 break; 248 248 case 2: 249 249 irq[n] = 9; 250 250 - /* Fall through */ 250 250 + fallthrough; 251 251 case 9: 252 252 wss_config[n] |= WSS_CONFIG_IRQ_9; 253 253 break; ··· 292 292 case 1: 293 293 if (dma1[n] == 0) 294 294 break; 295 295 - /* Fall through */ 295 295 + fallthrough; 296 296 default: 297 297 dev_err(dev, "invalid capture DMA %d\n", dma2[n]); 298 298 return 0; ··· 322 322 break; 323 323 case 2: 324 324 mpu_irq[n] = 9; 325 325 - /* Fall through */ 325 325 + fallthrough; 326 326 case 9: 327 327 config[n] |= GALAXY_CONFIG_MPUIRQ_2; 328 328 break;

+1 -3

sound/isa/msnd/msnd_pinnacle_mixer.c

reviewed

··· 219 219 case MSND_MIXER_VOLUME: /* master volume */ 220 220 writew(wLeft, dev->SMA + SMA_wCurrMastVolLeft); 221 221 writew(wRight, dev->SMA + SMA_wCurrMastVolRight); 222 222 - /* fall through */ 223 223 - 222 222 + fallthrough; 224 223 case MSND_MIXER_AUX: /* aux pot control */ 225 224 /* scaled by master volume */ 226 226 - /* fall through */ 227 225 228 226 /* digital controls */ 229 227 case MSND_MIXER_SYNTH: /* synth vol (dsp mix) */

+5 -5

sound/isa/opti9xx/miro.c

reviewed

··· 163 163 switch (timeout-ACI_MINTIME) { 164 164 case 0 ... 9: 165 165 out /= 10; 166 166 - /* fall through */ 166 166 + fallthrough; 167 167 case 10 ... 19: 168 168 out /= 10; 169 169 - /* fall through */ 169 169 + fallthrough; 170 170 case 20 ... 30: 171 171 out /= 10; 172 172 - /* fall through */ 172 172 + fallthrough; 173 173 default: 174 174 set_current_state(TASK_UNINTERRUPTIBLE); 175 175 schedule_timeout(out); ··· 824 824 retval = inb(chip->mc_base + 9); 825 825 break; 826 826 } 827 827 - /* fall through */ 827 827 + fallthrough; 828 828 829 829 case OPTi9XX_HW_82C929: 830 830 retval = inb(chip->mc_base + reg); ··· 854 854 outb(value, chip->mc_base + 9); 855 855 break; 856 856 } 857 857 - /* fall through */ 857 857 + fallthrough; 858 858 859 859 case OPTi9XX_HW_82C929: 860 860 outb(value, chip->mc_base + reg);

+7 -5

sound/isa/opti9xx/opti92x-ad1848.c

reviewed

··· 249 249 retval = inb(chip->mc_base + 9); 250 250 break; 251 251 } 252 252 - /* Fall through */ 252 252 + fallthrough; 253 253 254 254 case OPTi9XX_HW_82C928: 255 255 case OPTi9XX_HW_82C929: ··· 292 292 outb(value, chip->mc_base + 9); 293 293 break; 294 294 } 295 295 - /* Fall through */ 295 295 + fallthrough; 296 296 297 297 case OPTi9XX_HW_82C928: 298 298 case OPTi9XX_HW_82C929: ··· 343 343 snd_opti9xx_write_mask(chip, OPTi9XX_MC_REG(4), 0xf0, 0xfc); 344 344 /* enable wave audio */ 345 345 snd_opti9xx_write_mask(chip, OPTi9XX_MC_REG(6), 0x02, 0x02); 346 346 - /* Fall through */ 346 346 + fallthrough; 347 347 348 348 case OPTi9XX_HW_82C925: 349 349 /* enable WSS mode */ ··· 380 380 case OPTi9XX_HW_82C931: 381 381 /* disable 3D sound (set GPIO1 as output, low) */ 382 382 snd_opti9xx_write_mask(chip, OPTi9XX_MC_REG(20), 0x04, 0x0c); 383 383 - /* fall through */ 383 383 + fallthrough; 384 384 + 384 385 case OPTi9XX_HW_82C933: 385 386 /* 386 387 * The BTC 1817DW has QS1000 wavetable which is connected ··· 393 392 * or digital input signal. 394 393 */ 395 394 snd_opti9xx_write_mask(chip, OPTi9XX_MC_REG(26), 0x01, 0x01); 396 396 - /* fall through */ 395 395 + fallthrough; 396 396 + 397 397 case OPTi9XX_HW_82C930: 398 398 snd_opti9xx_write_mask(chip, OPTi9XX_MC_REG(6), 0x02, 0x03); 399 399 snd_opti9xx_write_mask(chip, OPTi9XX_MC_REG(3), 0x00, 0xff);

+5 -5

sound/isa/sb/sb8_main.c

reviewed

··· 116 116 chip->playback_format = SB_DSP_HI_OUTPUT_AUTO; 117 117 break; 118 118 } 119 119 - /* fall through */ 119 119 + fallthrough; 120 120 case SB_HW_201: 121 121 if (rate > 23000) { 122 122 chip->playback_format = SB_DSP_HI_OUTPUT_AUTO; 123 123 break; 124 124 } 125 125 - /* fall through */ 125 125 + fallthrough; 126 126 case SB_HW_20: 127 127 chip->playback_format = SB_DSP_LO_OUTPUT_AUTO; 128 128 break; ··· 261 261 chip->capture_format = SB_DSP_HI_INPUT_AUTO; 262 262 break; 263 263 } 264 264 - /* fall through */ 264 264 + fallthrough; 265 265 case SB_HW_20: 266 266 chip->capture_format = SB_DSP_LO_INPUT_AUTO; 267 267 break; ··· 361 361 case SB_MODE_PLAYBACK_16: /* ok.. playback is active */ 362 362 if (chip->hardware != SB_HW_JAZZ16) 363 363 break; 364 364 - /* fall through */ 364 364 + fallthrough; 365 365 case SB_MODE_PLAYBACK_8: 366 366 substream = chip->playback_substream; 367 367 if (chip->playback_format == SB_DSP_OUTPUT) ··· 371 371 case SB_MODE_CAPTURE_16: 372 372 if (chip->hardware != SB_HW_JAZZ16) 373 373 break; 374 374 - /* fall through */ 374 374 + fallthrough; 375 375 case SB_MODE_CAPTURE_8: 376 376 substream = chip->capture_substream; 377 377 if (chip->capture_format == SB_DSP_INPUT)

+1 -1

sound/oss/dmasound/dmasound_atari.c

reviewed

··· 1449 1449 tt_dmasnd.input_gain = 1450 1450 RECLEVEL_VOXWARE_TO_GAIN(data & 0xff) << 4 | 1451 1451 RECLEVEL_VOXWARE_TO_GAIN(data >> 8 & 0xff); 1452 1452 - /* fall through - return set value */ 1452 1452 + fallthrough; /* return set value */ 1453 1453 case SOUND_MIXER_READ_MIC: 1454 1454 return IOCTL_OUT(arg, 1455 1455 RECLEVEL_GAIN_TO_VOXWARE(tt_dmasnd.input_gain >> 4 & 0xf) |

+2 -2

sound/oss/dmasound/dmasound_core.c

reviewed

··· 1478 1478 printk("dmasound_setup: invalid catch radius, using default = %d\n", catchRadius); 1479 1479 else 1480 1480 catchRadius = ints[3]; 1481 1481 - /* fall through */ 1481 1481 + fallthrough; 1482 1482 case 2: 1483 1483 if (ints[1] < MIN_BUFFERS) 1484 1484 printk("dmasound_setup: invalid number of buffers, using default = %d\n", numWriteBufs); 1485 1485 else 1486 1486 numWriteBufs = ints[1]; 1487 1487 - /* fall through */ 1487 1487 + fallthrough; 1488 1488 case 1: 1489 1489 if ((size = ints[2]) < 256) /* check for small buffer specs */ 1490 1490 size <<= 10 ;

+2 -2

sound/pci/ac97/ac97_codec.c

reviewed

··· 218 218 case AC97_ID_ST_AC97_ID4: 219 219 if (reg == 0x08) 220 220 return 0; 221 221 - /* fall through */ 221 221 + fallthrough; 222 222 case AC97_ID_ST7597: 223 223 if (reg == 0x22 || reg == 0x7a) 224 224 return 1; 225 225 - /* fall through */ 225 225 + fallthrough; 226 226 case AC97_ID_AK4540: 227 227 case AC97_ID_AK4542: 228 228 if (reg <= 0x1c || reg == 0x20 || reg == 0x26 || reg >= 0x7c)

+3 -3

sound/pci/atiixp.c

reviewed

··· 896 896 case 8: 897 897 data |= ATI_REG_OUT_DMA_SLOT_BIT(10) | 898 898 ATI_REG_OUT_DMA_SLOT_BIT(11); 899 899 - /* fall through */ 899 899 + fallthrough; 900 900 case 6: 901 901 data |= ATI_REG_OUT_DMA_SLOT_BIT(7) | 902 902 ATI_REG_OUT_DMA_SLOT_BIT(8); 903 903 - /* fall through */ 903 903 + fallthrough; 904 904 case 4: 905 905 data |= ATI_REG_OUT_DMA_SLOT_BIT(6) | 906 906 ATI_REG_OUT_DMA_SLOT_BIT(9); 907 907 - /* fall through */ 907 907 + fallthrough; 908 908 default: 909 909 data |= ATI_REG_OUT_DMA_SLOT_BIT(3) | 910 910 ATI_REG_OUT_DMA_SLOT_BIT(4);

+1 -1

sound/pci/azt3328.c

reviewed

··· 1232 1232 case AZF_FREQ_32000: freq = SOUNDFORMAT_FREQ_32000; break; 1233 1233 default: 1234 1234 snd_printk(KERN_WARNING "unknown bitrate %d, assuming 44.1kHz!\n", bitrate); 1235 1235 - /* fall-through */ 1235 1235 + fallthrough; 1236 1236 case AZF_FREQ_44100: freq = SOUNDFORMAT_FREQ_44100; break; 1237 1237 case AZF_FREQ_48000: freq = SOUNDFORMAT_FREQ_48000; break; 1238 1238 case AZF_FREQ_66200: freq = SOUNDFORMAT_FREQ_SUSPECTED_66200; break;

+2 -2

sound/pci/echoaudio/echoaudio.c

reviewed

··· 699 699 break; 700 700 case SNDRV_PCM_FORMAT_S32_BE: 701 701 format.data_are_bigendian = 1; 702 702 - /* fall through */ 702 702 + fallthrough; 703 703 case SNDRV_PCM_FORMAT_S32_LE: 704 704 format.bits_per_sample = 32; 705 705 break; ··· 764 764 pipe->last_counter = 0; 765 765 pipe->position = 0; 766 766 *pipe->dma_counter = 0; 767 767 - /* fall through */ 767 767 + fallthrough; 768 768 case PIPE_STATE_PAUSED: 769 769 pipe->state = PIPE_STATE_STARTED; 770 770 break;

+2 -3

sound/pci/emu10k1/emupcm.c

reviewed

··· 753 753 case SNDRV_PCM_TRIGGER_START: 754 754 snd_emu10k1_playback_invalidate_cache(emu, 1, epcm->extra); /* do we need this? */ 755 755 snd_emu10k1_playback_invalidate_cache(emu, 0, epcm->voices[0]); 756 756 - /* fall through */ 756 756 + fallthrough; 757 757 case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: 758 758 case SNDRV_PCM_TRIGGER_RESUME: 759 759 if (cmd == SNDRV_PCM_TRIGGER_PAUSE_RELEASE) ··· 902 902 snd_emu10k1_playback_invalidate_cache(emu, 0, epcm->voices[i]); 903 903 } 904 904 snd_emu10k1_playback_invalidate_cache(emu, 1, epcm->extra); 905 905 - 906 906 - /* fall through */ 905 905 + fallthrough; 907 906 case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: 908 907 case SNDRV_PCM_TRIGGER_RESUME: 909 908 snd_emu10k1_playback_prepare_voice(emu, epcm->extra, 1, 1, NULL);

+1 -1

sound/pci/hda/hda_beep.c

reviewed

··· 102 102 case SND_BELL: 103 103 if (hz) 104 104 hz = 1000; 105 105 - /* fallthru */ 105 105 + fallthrough; 106 106 case SND_TONE: 107 107 if (beep->linear_tone) 108 108 beep->tone = beep_linear_tone(beep, hz);

+1 -1

sound/pci/hda/patch_conexant.c

reviewed

··· 1018 1018 break; 1019 1019 case 0x14f150f2: 1020 1020 codec->power_save_node = 1; 1021 1021 - /* Fall through */ 1021 1021 + fallthrough; 1022 1022 default: 1023 1023 codec->pin_amp_workaround = 1; 1024 1024 snd_hda_pick_fixup(codec, cxt5066_fixup_models,

+2 -2

sound/pci/hda/patch_realtek.c

reviewed

··· 382 382 case 0x10ec0295: 383 383 case 0x10ec0299: 384 384 alc_update_coef_idx(codec, 0x67, 0xf000, 0x3000); 385 385 - /* fallthrough */ 385 385 + fallthrough; 386 386 case 0x10ec0215: 387 387 case 0x10ec0233: 388 388 case 0x10ec0235: ··· 4697 4697 break; 4698 4698 case 0x10ec0867: 4699 4699 alc_update_coefex_idx(codec, 0x57, 0x5, 0, 1<<14); 4700 4700 - /* fallthru */ 4700 4700 + fallthrough; 4701 4701 case 0x10ec0221: 4702 4702 case 0x10ec0662: 4703 4703 snd_hda_set_pin_ctl_cache(codec, hp_pin, 0);

+1 -1

sound/pci/ice1712/delta.c

reviewed

··· 691 691 break; 692 692 case ICE1712_SUBDEVICE_DELTADIO2496: 693 693 ice->gpio.set_pro_rate = delta_1010_set_rate_val; 694 694 - /* fall thru */ 694 694 + fallthrough; 695 695 case ICE1712_SUBDEVICE_DELTA66: 696 696 ice->spdif.ops.open = delta_open_spdif; 697 697 ice->spdif.ops.setup_rate = delta_setup_spdif;

+4 -4

sound/pci/intel8x0.c

reviewed

··· 810 810 switch (cmd) { 811 811 case SNDRV_PCM_TRIGGER_RESUME: 812 812 ichdev->suspended = 0; 813 813 - /* fall through */ 813 813 + fallthrough; 814 814 case SNDRV_PCM_TRIGGER_START: 815 815 case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: 816 816 val = ICH_IOCE | ICH_STARTBM; ··· 818 818 break; 819 819 case SNDRV_PCM_TRIGGER_SUSPEND: 820 820 ichdev->suspended = 1; 821 821 - /* fall through */ 821 821 + fallthrough; 822 822 case SNDRV_PCM_TRIGGER_STOP: 823 823 val = 0; 824 824 break; ··· 852 852 switch (cmd) { 853 853 case SNDRV_PCM_TRIGGER_RESUME: 854 854 ichdev->suspended = 0; 855 855 - /* fall through */ 855 855 + fallthrough; 856 856 case SNDRV_PCM_TRIGGER_START: 857 857 case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: 858 858 if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { ··· 869 869 break; 870 870 case SNDRV_PCM_TRIGGER_SUSPEND: 871 871 ichdev->suspended = 1; 872 872 - /* fall through */ 872 872 + fallthrough; 873 873 case SNDRV_PCM_TRIGGER_STOP: 874 874 case SNDRV_PCM_TRIGGER_PAUSE_PUSH: 875 875 /* pause */

+1 -1

sound/pci/mixart/mixart.c

reviewed

··· 169 169 case PIPE_RUNNING: 170 170 if(rate != 0) 171 171 break; 172 172 - /* fall through */ 172 172 + fallthrough; 173 173 default: 174 174 if(rate == 0) 175 175 return 0; /* nothing to do */

+1 -1

sound/pci/mixart/mixart_core.c

reviewed

··· 527 527 dev_err(&mgr->pci->dev, 528 528 "canceled notification %x !\n", msg); 529 529 } 530 530 - /* fall through */ 530 530 + fallthrough; 531 531 case MSG_TYPE_ANSWER: 532 532 /* answer or notification to a message we are waiting for*/ 533 533 mutex_lock(&mgr->msg_lock);

+3 -3

sound/pci/nm256/nm256.c

reviewed

··· 560 560 switch (cmd) { 561 561 case SNDRV_PCM_TRIGGER_RESUME: 562 562 s->suspended = 0; 563 563 - /* fallthru */ 563 563 + fallthrough; 564 564 case SNDRV_PCM_TRIGGER_START: 565 565 if (! s->running) { 566 566 snd_nm256_playback_start(chip, s, substream); ··· 569 569 break; 570 570 case SNDRV_PCM_TRIGGER_SUSPEND: 571 571 s->suspended = 1; 572 572 - /* fallthru */ 572 572 + fallthrough; 573 573 case SNDRV_PCM_TRIGGER_STOP: 574 574 if (s->running) { 575 575 snd_nm256_playback_stop(chip); ··· 1664 1664 return -ENODEV; 1665 1665 case NM_RESET_WORKAROUND_2: 1666 1666 reset_workaround_2 = 1; 1667 1667 - /* Fall-through */ 1667 1667 + fallthrough; 1668 1668 case NM_RESET_WORKAROUND: 1669 1669 reset_workaround = 1; 1670 1670 break;

+1 -1

sound/pci/ymfpci/ymfpci_main.c

reviewed

··· 400 400 kctl = chip->pcm_mixer[substream->number].ctl; 401 401 kctl->vd[0].access |= SNDRV_CTL_ELEM_ACCESS_INACTIVE; 402 402 } 403 403 - /* fall through */ 403 403 + fallthrough; 404 404 case SNDRV_PCM_TRIGGER_PAUSE_PUSH: 405 405 case SNDRV_PCM_TRIGGER_SUSPEND: 406 406 chip->ctrl_playback[ypcm->voices[0]->number + 1] = 0;

+2 -2

sound/pcmcia/pdaudiocf/pdaudiocf_pcm.c

reviewed

··· 45 45 case SNDRV_PCM_TRIGGER_START: 46 46 chip->pcm_hwptr = 0; 47 47 chip->pcm_tdone = 0; 48 48 - /* fall thru */ 48 48 + fallthrough; 49 49 case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: 50 50 case SNDRV_PCM_TRIGGER_RESUME: 51 51 mask = 0; ··· 132 132 case SNDRV_PCM_FORMAT_S24_3LE: 133 133 case SNDRV_PCM_FORMAT_S24_3BE: 134 134 chip->pcm_sample = 3; 135 135 - /* fall through */ 135 135 + fallthrough; 136 136 default: /* 24-bit */ 137 137 aval = AK4117_DIF_24R; 138 138 chip->pcm_frame = 3;

+4 -4

sound/sparc/dbri.c

reviewed

··· 580 580 switch (len) { 581 581 case 32: 582 582 b = ((b & 0xffff0000) >> 16) | ((b & 0x0000ffff) << 16); 583 583 - /* fall through */ 583 583 + fallthrough; 584 584 case 16: 585 585 b = ((b & 0xff00ff00) >> 8) | ((b & 0x00ff00ff) << 8); 586 586 - /* fall through */ 586 586 + fallthrough; 587 587 case 8: 588 588 b = ((b & 0xf0f0f0f0) >> 4) | ((b & 0x0f0f0f0f) << 4); 589 589 - /* fall through */ 589 589 + fallthrough; 590 590 case 4: 591 591 b = ((b & 0xcccccccc) >> 2) | ((b & 0x33333333) << 2); 592 592 - /* fall through */ 592 592 + fallthrough; 593 593 case 2: 594 594 b = ((b & 0xaaaaaaaa) >> 1) | ((b & 0x55555555) << 1); 595 595 case 1:

+1 -1

sound/usb/card.c

reviewed

··· 230 230 dev_warn(&dev->dev, 231 231 "unknown interface protocol %#02x, assuming v1\n", 232 232 protocol); 233 233 - /* fall through */ 233 233 + fallthrough; 234 234 235 235 case UAC_VERSION_1: { 236 236 struct uac1_ac_header_descriptor *h1;

+1 -1

sound/usb/clock.c

reviewed

··· 670 670 else 671 671 return 0; 672 672 } 673 673 - /* fall through */ 673 673 + fallthrough; 674 674 case UAC_VERSION_2: 675 675 return set_sample_rate_v2v3(chip, iface, alts, fmt, rate); 676 676 }

+1 -1

sound/usb/pcm.c

reviewed

··· 1742 1742 switch (cmd) { 1743 1743 case SNDRV_PCM_TRIGGER_START: 1744 1744 subs->trigger_tstamp_pending_update = true; 1745 1745 - /* fall through */ 1745 1745 + fallthrough; 1746 1746 case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: 1747 1747 subs->data_endpoint->prepare_data_urb = prepare_playback_urb; 1748 1748 subs->data_endpoint->retire_data_urb = retire_playback_urb;

+1 -2

sound/usb/stream.c

reviewed

··· 1146 1146 dev_dbg(&dev->dev, "%u:%d: unknown interface protocol %#02x, assuming v1\n", 1147 1147 iface_no, altno, protocol); 1148 1148 protocol = UAC_VERSION_1; 1149 1149 - /* fall through */ 1149 1149 + fallthrough; 1150 1150 case UAC_VERSION_1: 1151 1151 - /* fall through */ 1152 1151 case UAC_VERSION_2: { 1153 1152 int bm_quirk = 0; 1154 1153