Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: advansys: use sg helper to iterate over scatterlist

Unlike the legacy I/O path, scsi-mq preallocates a large array to hold
the scatterlist for each request. This static allocation can consume
substantial amounts of memory on modern controllers which support a
large number of concurrently outstanding requests.

To facilitate a switch to a smaller static allocation combined with a
dynamic allocation for requests that need it, we need to make sure all
SCSI drivers handle chained scatterlists correctly.

Convert remaining drivers that directly dereference the scatterlist
array to using the iterator functions.

[mkp: clarified commit message]

Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Ming Lei and committed by
Martin K. Petersen
c0d0d81a cf9648cb

+1 -1
+1 -1
drivers/scsi/advansys.c
··· 7714 7714 sg_block->sg_ptr = 0L; /* Last ADV_SG_BLOCK in list. */ 7715 7715 return ADV_SUCCESS; 7716 7716 } 7717 - slp++; 7717 + slp = sg_next(slp); 7718 7718 } 7719 7719 sg_block->sg_cnt = NO_OF_SG_PER_BLOCK; 7720 7720 prev_sg_block = sg_block;