Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

power: supply: test_power: add missing newlines when printing parameters by sysfs

When I cat some module parameters by sysfs, it displays as follows.
It's better to add a newline for easy reading.

root@syzkaller:~# cd /sys/module/test_power/parameters/
root@syzkaller:/sys/module/test_power/parameters# cat ac_online
onroot@syzkaller:/sys/module/test_power/parameters# cat battery_present
trueroot@syzkaller:/sys/module/test_power/parameters# cat battery_health
goodroot@syzkaller:/sys/module/test_power/parameters# cat battery_status
dischargingroot@syzkaller:/sys/module/test_power/parameters# cat battery_technology
LIONroot@syzkaller:/sys/module/test_power/parameters# cat usb_online
onroot@syzkaller:/sys/module/test_power/parameters#

Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

authored by

Xiongfeng Wang and committed by
Sebastian Reichel
c07fa6c1 f87d092f

+6
+6
drivers/power/supply/test_power.c
··· 353 353 static int param_get_ac_online(char *buffer, const struct kernel_param *kp) 354 354 { 355 355 strcpy(buffer, map_get_key(map_ac_online, ac_online, "unknown")); 356 + strcat(buffer, "\n"); 356 357 return strlen(buffer); 357 358 } 358 359 ··· 367 366 static int param_get_usb_online(char *buffer, const struct kernel_param *kp) 368 367 { 369 368 strcpy(buffer, map_get_key(map_ac_online, usb_online, "unknown")); 369 + strcat(buffer, "\n"); 370 370 return strlen(buffer); 371 371 } 372 372 ··· 382 380 static int param_get_battery_status(char *buffer, const struct kernel_param *kp) 383 381 { 384 382 strcpy(buffer, map_get_key(map_status, battery_status, "unknown")); 383 + strcat(buffer, "\n"); 385 384 return strlen(buffer); 386 385 } 387 386 ··· 397 394 static int param_get_battery_health(char *buffer, const struct kernel_param *kp) 398 395 { 399 396 strcpy(buffer, map_get_key(map_health, battery_health, "unknown")); 397 + strcat(buffer, "\n"); 400 398 return strlen(buffer); 401 399 } 402 400 ··· 413 409 const struct kernel_param *kp) 414 410 { 415 411 strcpy(buffer, map_get_key(map_present, battery_present, "unknown")); 412 + strcat(buffer, "\n"); 416 413 return strlen(buffer); 417 414 } 418 415 ··· 431 426 { 432 427 strcpy(buffer, 433 428 map_get_key(map_technology, battery_technology, "unknown")); 429 + strcat(buffer, "\n"); 434 430 return strlen(buffer); 435 431 } 436 432