Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

sh: stacktrace: Remove stacktrace_ops.stack()

The SH implementation never called stacktrace_ops.stack().
Presumably this was copied from the x86 implementation.

Hence remove the method, and all implementations (most of them are
dummies).

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rich Felker <dalias@libc.org>

authored by

Geert Uytterhoeven and committed by
Rich Felker
c0735ae9 eac1a488

-29
-2
arch/sh/include/asm/stacktrace.h
··· 12 12 13 13 struct stacktrace_ops { 14 14 void (*address)(void *data, unsigned long address, int reliable); 15 - /* On negative return stop dumping */ 16 - int (*stack)(void *data, char *name); 17 15 }; 18 16 19 17 void dump_trace(struct task_struct *tsk, struct pt_regs *regs,
-7
arch/sh/kernel/dumpstack.c
··· 107 107 } 108 108 } 109 109 110 - static int print_trace_stack(void *data, char *name) 111 - { 112 - printk("%s <%s> ", (char *)data, name); 113 - return 0; 114 - } 115 - 116 110 /* 117 111 * Print one address/symbol entries per line. 118 112 */ ··· 117 123 } 118 124 119 125 static const struct stacktrace_ops print_trace_ops = { 120 - .stack = print_trace_stack, 121 126 .address = print_trace_address, 122 127 }; 123 128
-6
arch/sh/kernel/perf_callchain.c
··· 11 11 #include <asm/unwinder.h> 12 12 #include <asm/ptrace.h> 13 13 14 - static int callchain_stack(void *data, char *name) 15 - { 16 - return 0; 17 - } 18 - 19 14 static void callchain_address(void *data, unsigned long addr, int reliable) 20 15 { 21 16 struct perf_callchain_entry_ctx *entry = data; ··· 20 25 } 21 26 22 27 static const struct stacktrace_ops callchain_ops = { 23 - .stack = callchain_stack, 24 28 .address = callchain_address, 25 29 }; 26 30
-7
arch/sh/kernel/stacktrace.c
··· 15 15 #include <asm/ptrace.h> 16 16 #include <asm/stacktrace.h> 17 17 18 - static int save_stack_stack(void *data, char *name) 19 - { 20 - return 0; 21 - } 22 - 23 18 /* 24 19 * Save stack-backtrace addresses into a stack_trace buffer. 25 20 */ ··· 35 40 } 36 41 37 42 static const struct stacktrace_ops save_stack_ops = { 38 - .stack = save_stack_stack, 39 43 .address = save_stack_address, 40 44 }; 41 45 ··· 67 73 } 68 74 69 75 static const struct stacktrace_ops save_stack_ops_nosched = { 70 - .stack = save_stack_stack, 71 76 .address = save_stack_address_nosched, 72 77 }; 73 78
-7
arch/sh/oprofile/backtrace.c
··· 19 19 #include <asm/sections.h> 20 20 #include <asm/stacktrace.h> 21 21 22 - static int backtrace_stack(void *data, char *name) 23 - { 24 - /* Yes, we want all stacks */ 25 - return 0; 26 - } 27 - 28 22 static void backtrace_address(void *data, unsigned long addr, int reliable) 29 23 { 30 24 unsigned int *depth = data; ··· 28 34 } 29 35 30 36 static struct stacktrace_ops backtrace_ops = { 31 - .stack = backtrace_stack, 32 37 .address = backtrace_address, 33 38 }; 34 39