Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf intel-pt: Fix off-by-one comparison on maximum code

The check for the maximum code is off-by-one; the current comparison of
a code that is INTEL_PT_ERR_MAX will cause the strlcpy to perform an out
of bounds array access on the intel_pt_err_msgs array.

Fix this with a >= comparison.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1461524203-10224-1-git-send-email-colin.king@canonical.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

authored by

Colin Ian King and committed by
Arnaldo Carvalho de Melo
c0664893 73b1794e

+1 -1
+1 -1
tools/perf/util/intel-pt-decoder/intel-pt-decoder.c
··· 356 356 357 357 int intel_pt__strerror(int code, char *buf, size_t buflen) 358 358 { 359 - if (code < 1 || code > INTEL_PT_ERR_MAX) 359 + if (code < 1 || code >= INTEL_PT_ERR_MAX) 360 360 code = INTEL_PT_ERR_UNK; 361 361 strlcpy(buf, intel_pt_err_msgs[code], buflen); 362 362 return 0;