Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

USB: ehci-sched.c: EHCI SITD scheduling bugfix

Without this patch, the driver won't check that the last fully-occupied
uframe for a new split transaction was vacant beforehand. This can
lead to a situation in which the first 188 bytes of a 192-byte
isochronous transfer are scheduled in the same uframe as an existing
interrupt transfer. The resulting schedule looks like this:

uframe 0: 188-byte isoc-OUT SSPLIT, 8-byte int-IN SSPLIT
uframe 1: 4-byte isoc-OUT SSPLIT

The SSPLITs are intermingled, causing an error in the downstream hub's
TT.

If you are having problems with devices or hub ports resetting, or failed
interrupt transfers, when you start using a USB audio or video (Isochronous)
device, this patch may help.


Signed-off-by: Dan Streetman <ddstreet@ieee.org>
Reported-by: Kung James <kong1191@gmail.com>
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
Cc: Alan Stern <stern@rowland.harvard.edu>


authored by

Dan Streetman and committed by
Greg Kroah-Hartman
c065c60e 37768adf

+1 -1
+1 -1
drivers/usb/host/ehci-sched.c
··· 323 323 * already scheduled transactions 324 324 */ 325 325 if (125 < usecs) { 326 - int ufs = (usecs / 125) - 1; 326 + int ufs = (usecs / 125); 327 327 int i; 328 328 for (i = uframe; i < (uframe + ufs) && i < 8; i++) 329 329 if (0 < tt_usecs[i]) {