Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

NFSv4: remove obviously bogus comparison from decode_getacl

We just set *acl_len to zero, and attrlen is unsigned, so this comparison
is clearly bogus. I have no idea what I was thinking.

Fixes a bug that caused getacl to fail over krb5p.

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

authored by

J. Bruce Fields and committed by
Trond Myklebust
c04871e6 3873bc50

+1 -2
+1 -2
fs/nfs/nfs4xdr.c
··· 3350 3350 attrlen, recvd); 3351 3351 return -EINVAL; 3352 3352 } 3353 - if (attrlen <= *acl_len) 3354 - xdr_read_pages(xdr, attrlen); 3353 + xdr_read_pages(xdr, attrlen); 3355 3354 *acl_len = attrlen; 3356 3355 } else 3357 3356 status = -EOPNOTSUPP;