Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

signal/nios2: Use force_sig_fault where appropriate

Filling in struct siginfo before calling force_sig_info a tedious and
error prone process, where once in a great while the wrong fields
are filled out, and siginfo has been inconsistently cleared.

Simplify this process by using the helper force_sig_fault. Which
takes as a parameters all of the information it needs, ensures
all of the fiddly bits of filling in struct siginfo are done properly
and then calls force_sig_info.

In short about a 5 line reduction in code for every time force_sig_info
is called, which makes the calling function clearer.

Cc: Ley Foon Tan <lftan@altera.com>
Cc: nios2-dev@lists.rocketboards.org
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>

+1 -8
+1 -8
arch/nios2/kernel/traps.c
··· 26 26 27 27 static void _send_sig(int signo, int code, unsigned long addr) 28 28 { 29 - siginfo_t info; 30 - 31 - clear_siginfo(&info); 32 - info.si_signo = signo; 33 - info.si_errno = 0; 34 - info.si_code = code; 35 - info.si_addr = (void __user *) addr; 36 - force_sig_info(signo, &info, current); 29 + force_sig_fault(signo, code, (void __user *) addr, current); 37 30 } 38 31 39 32 void die(const char *str, struct pt_regs *regs, long err)