Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

md.c: re-indent various 'switch' statements.

Intent was unnecessarily deep.

Also change one 'switch' which has a single case element, into an
'if'.

Signed-off-by: NeilBrown <neilb@suse.de>

NeilBrown c02c0aeb a7a3f08d

+114 -123
+114 -123
drivers/md/md.c
··· 6347 6347 * Commands dealing with the RAID driver but not any 6348 6348 * particular array: 6349 6349 */ 6350 - switch (cmd) 6351 - { 6352 - case RAID_VERSION: 6353 - err = get_version(argp); 6354 - goto done; 6350 + switch (cmd) { 6351 + case RAID_VERSION: 6352 + err = get_version(argp); 6353 + goto done; 6355 6354 6356 - case PRINT_RAID_DEBUG: 6357 - err = 0; 6358 - md_print_devices(); 6359 - goto done; 6355 + case PRINT_RAID_DEBUG: 6356 + err = 0; 6357 + md_print_devices(); 6358 + goto done; 6360 6359 6361 6360 #ifndef MODULE 6362 - case RAID_AUTORUN: 6363 - err = 0; 6364 - autostart_arrays(arg); 6365 - goto done; 6361 + case RAID_AUTORUN: 6362 + err = 0; 6363 + autostart_arrays(arg); 6364 + goto done; 6366 6365 #endif 6367 - default:; 6366 + default:; 6368 6367 } 6369 6368 6370 6369 /* ··· 6410 6411 goto abort; 6411 6412 } 6412 6413 6413 - switch (cmd) 6414 - { 6415 - case SET_ARRAY_INFO: 6416 - { 6417 - mdu_array_info_t info; 6418 - if (!arg) 6419 - memset(&info, 0, sizeof(info)); 6420 - else if (copy_from_user(&info, argp, sizeof(info))) { 6421 - err = -EFAULT; 6422 - goto abort_unlock; 6423 - } 6424 - if (mddev->pers) { 6425 - err = update_array_info(mddev, &info); 6426 - if (err) { 6427 - printk(KERN_WARNING "md: couldn't update" 6428 - " array info. %d\n", err); 6429 - goto abort_unlock; 6430 - } 6431 - goto done_unlock; 6432 - } 6433 - if (!list_empty(&mddev->disks)) { 6434 - printk(KERN_WARNING 6435 - "md: array %s already has disks!\n", 6436 - mdname(mddev)); 6437 - err = -EBUSY; 6438 - goto abort_unlock; 6439 - } 6440 - if (mddev->raid_disks) { 6441 - printk(KERN_WARNING 6442 - "md: array %s already initialised!\n", 6443 - mdname(mddev)); 6444 - err = -EBUSY; 6445 - goto abort_unlock; 6446 - } 6447 - err = set_array_info(mddev, &info); 6448 - if (err) { 6449 - printk(KERN_WARNING "md: couldn't set" 6450 - " array info. %d\n", err); 6451 - goto abort_unlock; 6452 - } 6414 + if (cmd == SET_ARRAY_INFO) { 6415 + mdu_array_info_t info; 6416 + if (!arg) 6417 + memset(&info, 0, sizeof(info)); 6418 + else if (copy_from_user(&info, argp, sizeof(info))) { 6419 + err = -EFAULT; 6420 + goto abort_unlock; 6421 + } 6422 + if (mddev->pers) { 6423 + err = update_array_info(mddev, &info); 6424 + if (err) { 6425 + printk(KERN_WARNING "md: couldn't update" 6426 + " array info. %d\n", err); 6427 + goto abort_unlock; 6453 6428 } 6454 6429 goto done_unlock; 6455 - 6456 - default:; 6430 + } 6431 + if (!list_empty(&mddev->disks)) { 6432 + printk(KERN_WARNING 6433 + "md: array %s already has disks!\n", 6434 + mdname(mddev)); 6435 + err = -EBUSY; 6436 + goto abort_unlock; 6437 + } 6438 + if (mddev->raid_disks) { 6439 + printk(KERN_WARNING 6440 + "md: array %s already initialised!\n", 6441 + mdname(mddev)); 6442 + err = -EBUSY; 6443 + goto abort_unlock; 6444 + } 6445 + err = set_array_info(mddev, &info); 6446 + if (err) { 6447 + printk(KERN_WARNING "md: couldn't set" 6448 + " array info. %d\n", err); 6449 + goto abort_unlock; 6450 + } 6451 + goto done_unlock; 6457 6452 } 6458 6453 6459 6454 /* ··· 6466 6473 /* 6467 6474 * Commands even a read-only array can execute: 6468 6475 */ 6469 - switch (cmd) 6470 - { 6471 - case GET_BITMAP_FILE: 6472 - err = get_bitmap_file(mddev, argp); 6476 + switch (cmd) { 6477 + case GET_BITMAP_FILE: 6478 + err = get_bitmap_file(mddev, argp); 6479 + goto done_unlock; 6480 + 6481 + case RESTART_ARRAY_RW: 6482 + err = restart_array(mddev); 6483 + goto done_unlock; 6484 + 6485 + case STOP_ARRAY: 6486 + err = do_md_stop(mddev, 0, bdev); 6487 + goto done_unlock; 6488 + 6489 + case STOP_ARRAY_RO: 6490 + err = md_set_readonly(mddev, bdev); 6491 + goto done_unlock; 6492 + 6493 + case BLKROSET: 6494 + if (get_user(ro, (int __user *)(arg))) { 6495 + err = -EFAULT; 6496 + goto done_unlock; 6497 + } 6498 + err = -EINVAL; 6499 + 6500 + /* if the bdev is going readonly the value of mddev->ro 6501 + * does not matter, no writes are coming 6502 + */ 6503 + if (ro) 6473 6504 goto done_unlock; 6474 6505 6475 - case RESTART_ARRAY_RW: 6506 + /* are we are already prepared for writes? */ 6507 + if (mddev->ro != 1) 6508 + goto done_unlock; 6509 + 6510 + /* transitioning to readauto need only happen for 6511 + * arrays that call md_write_start 6512 + */ 6513 + if (mddev->pers) { 6476 6514 err = restart_array(mddev); 6477 - goto done_unlock; 6478 - 6479 - case STOP_ARRAY: 6480 - err = do_md_stop(mddev, 0, bdev); 6481 - goto done_unlock; 6482 - 6483 - case STOP_ARRAY_RO: 6484 - err = md_set_readonly(mddev, bdev); 6485 - goto done_unlock; 6486 - 6487 - case BLKROSET: 6488 - if (get_user(ro, (int __user *)(arg))) { 6489 - err = -EFAULT; 6490 - goto done_unlock; 6515 + if (err == 0) { 6516 + mddev->ro = 2; 6517 + set_disk_ro(mddev->gendisk, 0); 6491 6518 } 6492 - err = -EINVAL; 6493 - 6494 - /* if the bdev is going readonly the value of mddev->ro 6495 - * does not matter, no writes are coming 6496 - */ 6497 - if (ro) 6498 - goto done_unlock; 6499 - 6500 - /* are we are already prepared for writes? */ 6501 - if (mddev->ro != 1) 6502 - goto done_unlock; 6503 - 6504 - /* transitioning to readauto need only happen for 6505 - * arrays that call md_write_start 6506 - */ 6507 - if (mddev->pers) { 6508 - err = restart_array(mddev); 6509 - if (err == 0) { 6510 - mddev->ro = 2; 6511 - set_disk_ro(mddev->gendisk, 0); 6512 - } 6513 - } 6514 - goto done_unlock; 6519 + } 6520 + goto done_unlock; 6515 6521 } 6516 6522 6517 6523 /* ··· 6532 6540 } 6533 6541 } 6534 6542 6535 - switch (cmd) 6543 + switch (cmd) { 6544 + case ADD_NEW_DISK: 6536 6545 { 6537 - case ADD_NEW_DISK: 6538 - { 6539 - mdu_disk_info_t info; 6540 - if (copy_from_user(&info, argp, sizeof(info))) 6541 - err = -EFAULT; 6542 - else 6543 - err = add_new_disk(mddev, &info); 6544 - goto done_unlock; 6545 - } 6546 + mdu_disk_info_t info; 6547 + if (copy_from_user(&info, argp, sizeof(info))) 6548 + err = -EFAULT; 6549 + else 6550 + err = add_new_disk(mddev, &info); 6551 + goto done_unlock; 6552 + } 6546 6553 6547 - case HOT_REMOVE_DISK: 6548 - err = hot_remove_disk(mddev, new_decode_dev(arg)); 6549 - goto done_unlock; 6554 + case HOT_REMOVE_DISK: 6555 + err = hot_remove_disk(mddev, new_decode_dev(arg)); 6556 + goto done_unlock; 6550 6557 6551 - case HOT_ADD_DISK: 6552 - err = hot_add_disk(mddev, new_decode_dev(arg)); 6553 - goto done_unlock; 6558 + case HOT_ADD_DISK: 6559 + err = hot_add_disk(mddev, new_decode_dev(arg)); 6560 + goto done_unlock; 6554 6561 6555 - case RUN_ARRAY: 6556 - err = do_md_run(mddev); 6557 - goto done_unlock; 6562 + case RUN_ARRAY: 6563 + err = do_md_run(mddev); 6564 + goto done_unlock; 6558 6565 6559 - case SET_BITMAP_FILE: 6560 - err = set_bitmap_file(mddev, (int)arg); 6561 - goto done_unlock; 6566 + case SET_BITMAP_FILE: 6567 + err = set_bitmap_file(mddev, (int)arg); 6568 + goto done_unlock; 6562 6569 6563 - default: 6564 - err = -EINVAL; 6565 - goto abort_unlock; 6570 + default: 6571 + err = -EINVAL; 6572 + goto abort_unlock; 6566 6573 } 6567 6574 6568 6575 done_unlock: