Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hpt366: fix HPT370 DMA timeouts

The big driver change in 2.4.19-rc1 introduced a regression for many HPT370[A]
chips -- DMA stopped to work completely, only causing endless timeouts...

The culprit has been identified (at last!): it turned to be the code resetting
the DMA state machine before each transfer. Stop doing it now as this counter-
measure has clearly caused more harm than good.

This should fix the kernel.org bug #7703.

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

authored by

Sergei Shtylyov and committed by
Bartlomiej Zolnierkiewicz
c018f1ee aefe6475

+3 -1
+3 -1
drivers/ide/hpt366.c
··· 114 114 * the register setting lists into the table indexed by the clock selected 115 115 * - set the correct hwif->ultra_mask for each individual chip 116 116 * - add Ultra and MW DMA mode filtering for the HPT37[24] based SATA cards 117 + * - stop resetting HPT370's state machine before each DMA transfer as that has 118 + * caused more harm than good 117 119 * Sergei Shtylyov, <sshtylyov@ru.mvista.com> or <source@mvista.com> 118 120 */ 119 121 ··· 135 133 #define DRV_NAME "hpt366" 136 134 137 135 /* various tuning parameters */ 138 - #define HPT_RESET_STATE_ENGINE 136 + #undef HPT_RESET_STATE_ENGINE 139 137 #undef HPT_DELAY_INTERRUPT 140 138 141 139 static const char *quirk_drives[] = {