Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

netdev: ARRAY_SIZE() cleanups

Convert array size calculations to use ARRAY_SIZE().

Signed-off-by: Alejandro Martinez Ruiz <alex@flawedcode.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

authored by

Alejandro Martinez Ruiz and committed by
David S. Miller
c00acf46 4c3616cd

+19 -38
+1 -2
drivers/net/e1000e/ethtool.c
··· 95 95 { "tx_dma_failed", E1000_STAT(tx_dma_failed) }, 96 96 }; 97 97 98 - #define E1000_GLOBAL_STATS_LEN \ 99 - sizeof(e1000_gstrings_stats) / sizeof(struct e1000_stats) 98 + #define E1000_GLOBAL_STATS_LEN ARRAY_SIZE(e1000_gstrings_stats) 100 99 #define E1000_STATS_LEN (E1000_GLOBAL_STATS_LEN) 101 100 static const char e1000_gstrings_test[][ETH_GSTRING_LEN] = { 102 101 "Register test (offline)", "Eeprom test (offline)",
+1 -2
drivers/net/e1000e/phy.c
··· 49 49 100, 105, 109, 113, 116, 119, 122, 124, 104, 109, 114, 118, 121, 50 50 124}; 51 51 #define IGP02E1000_CABLE_LENGTH_TABLE_SIZE \ 52 - (sizeof(e1000_igp_2_cable_length_table) / \ 53 - sizeof(e1000_igp_2_cable_length_table[0])) 52 + ARRAY_SIZE(e1000_igp_2_cable_length_table) 54 53 55 54 /** 56 55 * e1000e_check_reset_block_generic - Check if PHY reset is blocked
+1 -2
drivers/net/ixgbe/ixgbe_ethtool.c
··· 96 96 ((((struct ixgbe_adapter *)netdev->priv)->num_tx_queues + \ 97 97 ((struct ixgbe_adapter *)netdev->priv)->num_rx_queues) * \ 98 98 (sizeof(struct ixgbe_queue_stats) / sizeof(u64))) 99 - #define IXGBE_GLOBAL_STATS_LEN \ 100 - sizeof(ixgbe_gstrings_stats) / sizeof(struct ixgbe_stats) 99 + #define IXGBE_GLOBAL_STATS_LEN ARRAY_SIZE(ixgbe_gstrings_stats) 101 100 #define IXGBE_STATS_LEN (IXGBE_GLOBAL_STATS_LEN + IXGBE_QUEUE_STATS_LEN) 102 101 103 102 static int ixgbe_get_settings(struct net_device *netdev,
+1 -1
drivers/net/tehuti.c
··· 621 621 static void __init bdx_firmware_endianess(void) 622 622 { 623 623 int i; 624 - for (i = 0; i < sizeof(s_firmLoad) / sizeof(u32); i++) 624 + for (i = 0; i < ARRAY_SIZE(s_firmLoad); i++) 625 625 s_firmLoad[i] = CPU_CHIP_SWAP32(s_firmLoad[i]); 626 626 } 627 627
+1 -1
drivers/net/tulip/de4x5.c
··· 4168 4168 { 4169 4169 int i, status = 0; 4170 4170 4171 - for (i=0; i<sizeof(enet_det)/ETH_ALEN; i++) { 4171 + for (i=0; i < ARRAY_SIZE(enet_det); i++) { 4172 4172 if (!de4x5_strncmp((char *)&lp->srom, (char *)&enet_det[i], 3) && 4173 4173 !de4x5_strncmp((char *)&lp->srom+0x10, (char *)&enet_det[i], 3)) { 4174 4174 if (i == 0) {
+1 -2
drivers/net/wireless/ipw2100.c
··· 6591 6591 2472, 2484 6592 6592 }; 6593 6593 6594 - #define FREQ_COUNT (sizeof(ipw2100_frequencies) / \ 6595 - sizeof(ipw2100_frequencies[0])) 6594 + #define FREQ_COUNT ARRAY_SIZE(ipw2100_frequencies) 6596 6595 6597 6596 static const long ipw2100_rates_11b[] = { 6598 6597 1000000,
+7 -17
drivers/net/wireless/libertas/11d.c
··· 46 46 static u8 wlan_region_2_code(u8 * region) 47 47 { 48 48 u8 i; 49 - u8 size = sizeof(region_code_mapping)/ 50 - sizeof(struct region_code_mapping); 51 49 52 50 for (i = 0; region[i] && i < COUNTRY_CODE_LEN; i++) 53 51 region[i] = toupper(region[i]); 54 52 55 - for (i = 0; i < size; i++) { 53 + for (i = 0; i < ARRAY_SIZE(region_code_mapping); i++) { 56 54 if (!memcmp(region, region_code_mapping[i].region, 57 55 COUNTRY_CODE_LEN)) 58 56 return (region_code_mapping[i].code); ··· 63 65 static u8 *wlan_code_2_region(u8 code) 64 66 { 65 67 u8 i; 66 - u8 size = sizeof(region_code_mapping) 67 - / sizeof(struct region_code_mapping); 68 - for (i = 0; i < size; i++) { 68 + 69 + for (i = 0; i < ARRAY_SIZE(region_code_mapping); i++) { 69 70 if (region_code_mapping[i].code == code) 70 71 return (region_code_mapping[i].region); 71 72 } ··· 87 90 u8 cfp_no; 88 91 89 92 cfp = channel_freq_power_UN_BG; 90 - cfp_no = sizeof(channel_freq_power_UN_BG) / 91 - sizeof(struct chan_freq_power); 93 + cfp_no = ARRAY_SIZE(channel_freq_power_UN_BG); 92 94 93 95 for (i = 0; i < cfp_no; i++) { 94 96 if ((cfp + i)->channel == firstchan) { ··· 137 141 u32 libertas_chan_2_freq(u8 chan, u8 band) 138 142 { 139 143 struct chan_freq_power *cf; 140 - u16 cnt; 141 144 u16 i; 142 145 u32 freq = 0; 143 146 144 147 cf = channel_freq_power_UN_BG; 145 - cnt = 146 - sizeof(channel_freq_power_UN_BG) / 147 - sizeof(struct chan_freq_power); 148 148 149 - for (i = 0; i < cnt; i++) { 149 + for (i = 0; i < ARRAY_SIZE(channel_freq_power_UN_BG); i++) { 150 150 if (chan == cf[i].channel) 151 151 freq = cf[i].freq; 152 152 } ··· 656 664 if (priv->adapter->enable11d) { 657 665 /* update parsed_region_chan_11; dnld domaininf to FW */ 658 666 659 - for (j = 0; j < sizeof(adapter->region_channel) / 660 - sizeof(adapter->region_channel[0]); j++) { 667 + for (j = 0; j < ARRAY_SIZE(adapter->region_channel); j++) { 661 668 region_chan = &adapter->region_channel[j]; 662 669 663 670 lbs_deb_11d("%d region_chan->band %d\n", j, ··· 670 679 break; 671 680 } 672 681 673 - if (j >= sizeof(adapter->region_channel) / 674 - sizeof(adapter->region_channel[0])) { 682 + if (j >= ARRAY_SIZE(adapter->region_channel)) { 675 683 lbs_deb_11d("region_chan not found, band %d\n", 676 684 adapter->curbssparams.band); 677 685 ret = -1;
+3 -8
drivers/net/wireless/libertas/wext.c
··· 52 52 { 53 53 struct chan_freq_power *cfp = NULL; 54 54 struct region_channel *rc; 55 - int count = sizeof(adapter->region_channel) / 56 - sizeof(adapter->region_channel[0]); 57 55 int i, j; 58 56 59 - for (j = 0; !cfp && (j < count); j++) { 57 + for (j = 0; !cfp && (j < ARRAY_SIZE(adapter->region_channel)); j++) { 60 58 rc = &adapter->region_channel[j]; 61 59 62 60 if (adapter->enable11d) ··· 91 93 { 92 94 struct chan_freq_power *cfp = NULL; 93 95 struct region_channel *rc; 94 - int count = sizeof(adapter->region_channel) / 95 - sizeof(adapter->region_channel[0]); 96 96 int i, j; 97 97 98 - for (j = 0; !cfp && (j < count); j++) { 98 + for (j = 0; !cfp && (j < ARRAY_SIZE(adapter->region_channel)); j++) { 99 99 rc = &adapter->region_channel[j]; 100 100 101 101 if (adapter->enable11d) ··· 620 624 } 621 625 if (!flag) { 622 626 for (j = 0; (range->num_frequency < IW_MAX_FREQUENCIES) 623 - && (j < sizeof(adapter->region_channel) 624 - / sizeof(adapter->region_channel[0])); j++) { 627 + && (j < ARRAY_SIZE(adapter->region_channel)); j++) { 625 628 cfp = adapter->region_channel[j].CFP; 626 629 for (i = 0; (range->num_frequency < IW_MAX_FREQUENCIES) 627 630 && adapter->region_channel[j].valid
+1 -1
drivers/net/wireless/wavelan.c
··· 3740 3740 * non-NCR/AT&T/Lucent ISA card. See wavelan.p.h for detail on 3741 3741 * how to configure your card. 3742 3742 */ 3743 - for (i = 0; i < (sizeof(MAC_ADDRESSES) / sizeof(char) / 3); i++) 3743 + for (i = 0; i < ARRAY_SIZE(MAC_ADDRESSES); i++) 3744 3744 if ((mac[0] == MAC_ADDRESSES[i][0]) && 3745 3745 (mac[1] == MAC_ADDRESSES[i][1]) && 3746 3746 (mac[2] == MAC_ADDRESSES[i][2]))
+2 -2
drivers/net/wireless/wavelan_cs.c
··· 3223 3223 * non-NCR/AT&T/Lucent PCMCIA cards, see wavelan_cs.h for detail on 3224 3224 * how to configure your card... 3225 3225 */ 3226 - for(i = 0; i < (sizeof(MAC_ADDRESSES) / sizeof(char) / 3); i++) 3226 + for(i = 0; i < ARRAY_SIZE(MAC_ADDRESSES); i++) 3227 3227 if((psa.psa_univ_mac_addr[0] == MAC_ADDRESSES[i][0]) && 3228 3228 (psa.psa_univ_mac_addr[1] == MAC_ADDRESSES[i][1]) && 3229 3229 (psa.psa_univ_mac_addr[2] == MAC_ADDRESSES[i][2])) 3230 3230 break; 3231 3231 3232 3232 /* If we have not found it... */ 3233 - if(i == (sizeof(MAC_ADDRESSES) / sizeof(char) / 3)) 3233 + if(i == ARRAY_SIZE(MAC_ADDRESSES)) 3234 3234 { 3235 3235 #ifdef DEBUG_CONFIG_ERRORS 3236 3236 printk(KERN_WARNING "%s: wv_mmc_init(): Invalid MAC address: %02X:%02X:%02X:...\n",