Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/amdkfd: check for null dev to avoid a null pointer dereference

The call to kfd_device_by_id can potentially return null, so check that
dev is null and return with -EINVAL to avoid a null pointer dereference.

Detected by CoverityScan CID#1454629 ("Dereference null return value")

Fixes: 5d71dbc3a588 ("drm/amdkfd: Implement image tiling mode support v2")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>

authored by

Colin Ian King and committed by
Oded Gabbay
bfaa1ce8 56eac98b

+2
+2
drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
··· 892 892 int err = 0; 893 893 894 894 dev = kfd_device_by_id(args->gpu_id); 895 + if (!dev) 896 + return -EINVAL; 895 897 896 898 dev->kfd2kgd->get_tile_config(dev->kgd, &config); 897 899