Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/vmwgfx: Fix an error return check in vmw_compat_shader_add()

In vmw_compat_shader_add(), the return value check of vmw_shader_alloc()
is not proper. Modify the check for the return pointer 'res'.

Found by code review and compiled on ubuntu 20.04.

Fixes: 18e4a4669c50 ("drm/vmwgfx: Fix compat shader namespace")
Cc: stable@vger.kernel.org
Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
Signed-off-by: Zack Rusin <zack.rusin@broadcom.com>
Link: https://patch.msgid.link/20251224091105.1569464-1-lihaoxiang@isrc.iscas.ac.cn

authored by

Haoxiang Li and committed by
Zack Rusin
bf72b4b7 37a0cff4

+3 -1
+3 -1
drivers/gpu/drm/vmwgfx/vmwgfx_shader.c
··· 923 923 ttm_bo_unreserve(&buf->tbo); 924 924 925 925 res = vmw_shader_alloc(dev_priv, buf, size, 0, shader_type); 926 - if (unlikely(ret != 0)) 926 + if (IS_ERR(res)) { 927 + ret = PTR_ERR(res); 927 928 goto no_reserve; 929 + } 928 930 929 931 ret = vmw_cmdbuf_res_add(man, vmw_cmdbuf_res_shader, 930 932 vmw_shader_key(user_key, shader_type),