Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[media] v4l: xilinx: VIDEO_XILINX should depend on HAS_DMA

If NO_DMA=y:

warning: (VIDEO_XILINX && VIDEO_DM365_VPFE && VIDEO_DT3155 && VIDEO_OMAP4) selects VIDEOBUF2_DMA_CONTIG which has unmet direct dependencies (MEDIA_SUPPORT && HAS_DMA)

media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’:
media/v4l2-core/videobuf2-dma-contig.c:207: error: implicit declaration of function ‘dma_mmap_coherent’
media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_get_base_sgt’:
media/v4l2-core/videobuf2-dma-contig.c:390: error: implicit declaration of function ‘dma_get_sgtable’

VIDEO_XILINX selects VIDEOBUF2_DMA_CONTIG, which bypasses its dependency
on HAS_DMA. Make VIDEO_XILINX depend on HAS_DMA to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

authored by

Geert Uytterhoeven and committed by
Mauro Carvalho Chehab
bf7096c6 45339d5b

+1 -1
+1 -1
drivers/media/platform/xilinx/Kconfig
··· 1 1 config VIDEO_XILINX 2 2 tristate "Xilinx Video IP (EXPERIMENTAL)" 3 - depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && OF 3 + depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && OF && HAS_DMA 4 4 select VIDEOBUF2_DMA_CONTIG 5 5 ---help--- 6 6 Driver for Xilinx Video IP Pipelines