Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

i2c-viapro: Don't log nacks

Transactions not acked can happen every now and then, in particular
during device detection, and various transaction types can be used for
this purpose. So stop logging this event, except when debugging is
enabled. This is what other similar drivers (e.g. i2c-i801 or
i2c-piix4) do.

Signed-off-by: Jean Delvare <khali@linux-fr.org>

authored by

Jean Delvare and committed by
Jean Delvare
bf5d95c8 db79f2a1

+1 -7
+1 -7
drivers/i2c/busses/i2c-viapro.c
··· 185 185 } 186 186 187 187 if (temp & 0x04) { 188 - int read = inb_p(SMBHSTADD) & 0x01; 189 188 result = -ENXIO; 190 - /* The quick and receive byte commands are used to probe 191 - for chips, so errors are expected, and we don't want 192 - to frighten the user. */ 193 - if (!((size == VT596_QUICK && !read) || 194 - (size == VT596_BYTE && read))) 195 - dev_err(&vt596_adapter.dev, "Transaction error!\n"); 189 + dev_dbg(&vt596_adapter.dev, "No response\n"); 196 190 } 197 191 198 192 /* Resetting status register */