Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

driver core: platform: Don't read past the end of "driver_override" buffer

When printing the driver_override parameter when it is 4095 and 4094 bytes
long, the printing code would access invalid memory because we need count+1
bytes for printing.

Reject driver_override values of these lengths in driver_override_store().

This is in close analogy to commit 4efe874aace5 ("PCI: Don't read past the
end of sysfs "driver_override" buffer") from Sasha Levin.

Fixes: 3d713e0e382e ("driver core: platform: add device binding path 'driver_override'")
Cc: stable@vger.kernel.org # v3.17+
Signed-off-by: Nicolai Stange <nstange@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Nicolai Stange and committed by
Greg Kroah-Hartman
bf563b01 452562ab

+2 -1
+2 -1
drivers/base/platform.c
··· 868 868 struct platform_device *pdev = to_platform_device(dev); 869 869 char *driver_override, *old, *cp; 870 870 871 - if (count > PATH_MAX) 871 + /* We need to keep extra room for a newline */ 872 + if (count >= (PAGE_SIZE - 1)) 872 873 return -EINVAL; 873 874 874 875 driver_override = kstrndup(buf, count, GFP_KERNEL);