Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

gpio/aspeed-sgpio: don't enable all interrupts by default

Currently, the IRQ setup for the SGPIO driver enables all interrupts in
dual-edge trigger mode. Since the default handler is handle_bad_irq, any
state change on input GPIOs will trigger bad IRQ warnings.

This change applies sensible IRQ defaults: single-edge trigger, and all
IRQs disabled.

Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Fixes: 7db47faae79b ("gpio: aspeed: Add SGPIO driver")
Reviewed-by: Joel Stanley <joel@jms.id.au>
Acked-by: Andrew Jeffery <andrew@aj.id.au>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

authored by

Jeremy Kerr and committed by
Bartosz Golaszewski
bf0d394e ac67b07e

+3 -5
+3 -5
drivers/gpio/gpio-aspeed-sgpio.c
··· 452 452 irq->parents = &gpio->irq; 453 453 irq->num_parents = 1; 454 454 455 - /* set IRQ settings and Enable Interrupt */ 455 + /* Apply default IRQ settings */ 456 456 for (i = 0; i < ARRAY_SIZE(aspeed_sgpio_banks); i++) { 457 457 bank = &aspeed_sgpio_banks[i]; 458 458 /* set falling or level-low irq */ 459 459 iowrite32(0x00000000, bank_reg(gpio, bank, reg_irq_type0)); 460 460 /* trigger type is edge */ 461 461 iowrite32(0x00000000, bank_reg(gpio, bank, reg_irq_type1)); 462 - /* dual edge trigger mode. */ 463 - iowrite32(0xffffffff, bank_reg(gpio, bank, reg_irq_type2)); 464 - /* enable irq */ 465 - iowrite32(0xffffffff, bank_reg(gpio, bank, reg_irq_enable)); 462 + /* single edge trigger */ 463 + iowrite32(0x00000000, bank_reg(gpio, bank, reg_irq_type2)); 466 464 } 467 465 468 466 return 0;