Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

b43: PHY: drop is_40mhz (get width info from chandef)

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

authored by

Rafał Miłecki and committed by
John W. Linville
bee6d4b2 39e971ef

+33 -35
-5
drivers/net/wireless/b43/main.c
··· 3810 3810 if (changed & IEEE80211_CONF_CHANGE_CHANNEL) { 3811 3811 phy->chandef = &conf->chandef; 3812 3812 phy->channel = conf->chandef.chan->hw_value; 3813 - if (conf_is_ht(conf)) 3814 - phy->is_40mhz = conf_is_ht40_minus(conf) || 3815 - conf_is_ht40_plus(conf); 3816 - else 3817 - phy->is_40mhz = false; 3818 3813 3819 3814 /* Switch the band (if necessary). */ 3820 3815 err = b43_switch_band(dev, conf->chandef.chan);
+5
drivers/net/wireless/b43/phy_common.c
··· 553 553 channel_type == NL80211_CHAN_HT40PLUS); 554 554 } 555 555 556 + bool b43_is_40mhz(struct b43_wldev *dev) 557 + { 558 + return dev->phy.chandef->width == NL80211_CHAN_WIDTH_40; 559 + } 560 + 556 561 /* http://bcm-v4.sipsolutions.net/802.11/PHY/N/BmacPhyClkFgc */ 557 562 void b43_phy_force_clock(struct b43_wldev *dev, bool force) 558 563 {
+2 -3
drivers/net/wireless/b43/phy_common.h
··· 228 228 bool supports_2ghz; 229 229 bool supports_5ghz; 230 230 231 - /* HT info */ 232 - bool is_40mhz; 233 - 234 231 /* Is GMODE (2 GHz mode) bit enabled? */ 235 232 bool gmode; 236 233 ··· 448 451 void b43_phyop_switch_analog_generic(struct b43_wldev *dev, bool on); 449 452 450 453 bool b43_channel_type_is_40mhz(enum nl80211_channel_type channel_type); 454 + 455 + bool b43_is_40mhz(struct b43_wldev *dev); 451 456 452 457 void b43_phy_force_clock(struct b43_wldev *dev, bool force); 453 458
+26 -27
drivers/net/wireless/b43/phy_n.c
··· 896 896 offset | B2056_TX_MIXG_BOOST_TUNE, 897 897 mixg_boost); 898 898 } else { 899 - bias = dev->phy.is_40mhz ? 0x40 : 0x20; 899 + bias = b43_is_40mhz(dev) ? 0x40 : 0x20; 900 900 b43_radio_write(dev, 901 901 offset | B2056_TX_INTPAG_IMAIN_STAT, 902 902 bias); ··· 1211 1211 u16 bw, len, rot, angle; 1212 1212 struct b43_c32 *samples; 1213 1213 1214 - 1215 - bw = (dev->phy.is_40mhz) ? 40 : 20; 1214 + bw = b43_is_40mhz(dev) ? 40 : 20; 1216 1215 len = bw << 3; 1217 1216 1218 1217 if (test) { ··· 1220 1221 else 1221 1222 bw = 80; 1222 1223 1223 - if (dev->phy.is_40mhz) 1224 + if (b43_is_40mhz(dev)) 1224 1225 bw <<= 1; 1225 1226 1226 1227 len = bw << 1; ··· 1263 1264 } 1264 1265 1265 1266 /* TODO: add modify_bbmult argument */ 1266 - if (!dev->phy.is_40mhz) 1267 + if (!b43_is_40mhz(dev)) 1267 1268 tmp = 0x6464; 1268 1269 else 1269 1270 tmp = 0x4747; ··· 2193 2194 b43_phy_write(dev, B43_NPHY_C1_NBCLIPTHRES, 0x84); 2194 2195 b43_phy_write(dev, B43_NPHY_C2_NBCLIPTHRES, 0x84); 2195 2196 2196 - if (!dev->phy.is_40mhz) { 2197 + if (!b43_is_40mhz(dev)) { 2197 2198 /* Set dwell lengths */ 2198 2199 b43_phy_write(dev, B43_NPHY_CLIP1_NBDWELL_LEN, 0x002B); 2199 2200 b43_phy_write(dev, B43_NPHY_CLIP2_NBDWELL_LEN, 0x002B); ··· 2207 2208 b43_phy_maskset(dev, B43_NPHY_C2_CLIPWBTHRES, 2208 2209 ~B43_NPHY_C2_CLIPWBTHRES_CLIP2, 21); 2209 2210 2210 - if (!dev->phy.is_40mhz) { 2211 + if (!b43_is_40mhz(dev)) { 2211 2212 b43_phy_maskset(dev, B43_NPHY_C1_CGAINI, 2212 2213 ~B43_NPHY_C1_CGAINI_GAINBKOFF, 0x1); 2213 2214 b43_phy_maskset(dev, B43_NPHY_C2_CGAINI, ··· 2222 2223 2223 2224 if (nphy->gain_boost) { 2224 2225 if (b43_current_band(dev->wl) == IEEE80211_BAND_2GHZ && 2225 - dev->phy.is_40mhz) 2226 + b43_is_40mhz(dev)) 2226 2227 code = 4; 2227 2228 else 2228 2229 code = 5; 2229 2230 } else { 2230 - code = dev->phy.is_40mhz ? 6 : 7; 2231 + code = b43_is_40mhz(dev) ? 6 : 7; 2231 2232 } 2232 2233 2233 2234 /* Set HPVGA2 index */ ··· 2299 2300 static u16 b43_nphy_read_lpf_ctl(struct b43_wldev *dev, u16 offset) 2300 2301 { 2301 2302 if (!offset) 2302 - offset = (dev->phy.is_40mhz) ? 0x159 : 0x154; 2303 + offset = b43_is_40mhz(dev) ? 0x159 : 0x154; 2303 2304 return b43_ntab_read(dev, B43_NTAB16(7, offset)) & 0x7; 2304 2305 } 2305 2306 ··· 2372 2373 lpf_40 = b43_nphy_read_lpf_ctl(dev, 0x159); 2373 2374 lpf_11b = b43_nphy_read_lpf_ctl(dev, 0x152); 2374 2375 if (b43_nphy_ipa(dev)) { 2375 - if ((phy->radio_rev == 5 && phy->is_40mhz) || 2376 + if ((phy->radio_rev == 5 && b43_is_40mhz(dev)) || 2376 2377 phy->radio_rev == 7 || phy->radio_rev == 8) { 2377 2378 bcap_val = b43_radio_read(dev, 0x16b); 2378 2379 scap_val = b43_radio_read(dev, 0x16a); 2379 2380 scap_val_11b = scap_val; 2380 2381 bcap_val_11b = bcap_val; 2381 - if (phy->radio_rev == 5 && phy->is_40mhz) { 2382 + if (phy->radio_rev == 5 && b43_is_40mhz(dev)) { 2382 2383 scap_val_11n_20 = scap_val; 2383 2384 bcap_val_11n_20 = bcap_val; 2384 2385 scap_val_11n_40 = bcap_val_11n_40 = 0xc; ··· 2520 2521 } 2521 2522 } 2522 2523 } else if (phy->radio_rev == 7 || phy->radio_rev == 8) { 2523 - if (!phy->is_40mhz) { 2524 + if (!b43_is_40mhz(dev)) { 2524 2525 b43_radio_write(dev, 0x5F, 0x14); 2525 2526 b43_radio_write(dev, 0xE8, 0x12); 2526 2527 } else { ··· 2593 2594 b43_ntab_write(dev, B43_NTAB16(7, 0x123), 0x77); 2594 2595 b43_ntab_write(dev, B43_NTAB16(7, 0x12A), 0x77); 2595 2596 2596 - if (!phy->is_40mhz) { 2597 + if (!b43_is_40mhz(dev)) { 2597 2598 b43_ntab_write(dev, B43_NTAB32(16, 0x03), 0x18D); 2598 2599 b43_ntab_write(dev, B43_NTAB32(16, 0x7F), 0x18D); 2599 2600 } else { ··· 2692 2693 2693 2694 b43_phy_maskset(dev, B43_NPHY_SGILTRNOFFSET, 0xF0FF, 0x0700); 2694 2695 2695 - if (!dev->phy.is_40mhz) { 2696 + if (!b43_is_40mhz(dev)) { 2696 2697 b43_ntab_write(dev, B43_NTAB32(16, 3), 0x18D); 2697 2698 b43_ntab_write(dev, B43_NTAB32(16, 127), 0x18D); 2698 2699 } else { ··· 3115 3116 b43_phy_maskset(dev, B43_NPHY_BPHY_CTL3, 3116 3117 ~B43_NPHY_BPHY_CTL3_SCALE, 0x5A); 3117 3118 3118 - if (dev->phy.rev < 2 && dev->phy.is_40mhz) 3119 + if (dev->phy.rev < 2 && b43_is_40mhz(dev)) 3119 3120 b43_hf_write(dev, b43_hf_read(dev) | B43_HF_TSSIRPSMW); 3120 3121 } else { 3121 3122 b43_ntab_write_bulk(dev, B43_NTAB16(26, 64), 84, ··· 3169 3170 else if (dev->phy.rev < 2) 3170 3171 b43_phy_maskset(dev, B43_NPHY_BPHY_CTL3, ~0xFF, 0x40); 3171 3172 3172 - if (dev->phy.rev < 2 && dev->phy.is_40mhz) 3173 + if (dev->phy.rev < 2 && b43_is_40mhz(dev)) 3173 3174 b43_hf_write(dev, b43_hf_read(dev) & ~B43_HF_TSSIRPSMW); 3174 3175 3175 3176 if (b43_nphy_ipa(dev)) { ··· 3441 3442 delta = 0; 3442 3443 switch (stf_mode) { 3443 3444 case 0: 3444 - if (dev->phy.is_40mhz && dev->phy.rev >= 5) { 3445 + if (b43_is_40mhz(dev) && dev->phy.rev >= 5) { 3445 3446 idx = 68; 3446 3447 } else { 3447 3448 delta = 1; 3448 - idx = dev->phy.is_40mhz ? 52 : 4; 3449 + idx = b43_is_40mhz(dev) ? 52 : 4; 3449 3450 } 3450 3451 break; 3451 3452 case 1: 3452 - idx = dev->phy.is_40mhz ? 76 : 28; 3453 + idx = b43_is_40mhz(dev) ? 76 : 28; 3453 3454 break; 3454 3455 case 2: 3455 - idx = dev->phy.is_40mhz ? 84 : 36; 3456 + idx = b43_is_40mhz(dev) ? 84 : 36; 3456 3457 break; 3457 3458 case 3: 3458 - idx = dev->phy.is_40mhz ? 92 : 44; 3459 + idx = b43_is_40mhz(dev) ? 92 : 44; 3459 3460 break; 3460 3461 } 3461 3462 ··· 3995 3996 3996 3997 if (nphy->gband_spurwar_en) { 3997 3998 /* TODO: N PHY Adjust Analog Pfbw (7) */ 3998 - if (channel == 11 && dev->phy.is_40mhz) 3999 + if (channel == 11 && b43_is_40mhz(dev)) 3999 4000 ; /* TODO: N PHY Adjust Min Noise Var(2, tone, noise)*/ 4000 4001 else 4001 4002 ; /* TODO: N PHY Adjust Min Noise Var(0, NULL, NULL)*/ ··· 4289 4290 b43_phy_write(dev, B43_PHY_N(offset[i] + j), 4290 4291 tbl_tx_filter_coef_rev4[i][j]); 4291 4292 4292 - if (dev->phy.is_40mhz) { 4293 + if (b43_is_40mhz(dev)) { 4293 4294 for (j = 0; j < 15; j++) 4294 4295 b43_phy_write(dev, B43_PHY_N(offset[0] + j), 4295 4296 tbl_tx_filter_coef_rev4[3][j]); ··· 4625 4626 (dev->phy.rev == 5 && nphy->ipa2g_on && 4626 4627 b43_current_band(dev->wl) == IEEE80211_BAND_2GHZ); 4627 4628 if (phy6or5x) { 4628 - if (dev->phy.is_40mhz) { 4629 + if (b43_is_40mhz(dev)) { 4629 4630 b43_ntab_write_bulk(dev, B43_NTAB16(15, 0), 18, 4630 4631 tbl_tx_iqlo_cal_loft_ladder_40); 4631 4632 b43_ntab_write_bulk(dev, B43_NTAB16(15, 32), 18, ··· 4640 4641 4641 4642 b43_phy_write(dev, B43_NPHY_IQLOCAL_CMDGCTL, 0x8AA9); 4642 4643 4643 - if (!dev->phy.is_40mhz) 4644 + if (!b43_is_40mhz(dev)) 4644 4645 freq = 2500; 4645 4646 else 4646 4647 freq = 5000; 4647 4648 4648 4649 if (nphy->mphase_cal_phase_id > 2) 4649 - b43_nphy_run_samples(dev, (dev->phy.is_40mhz ? 40 : 20) * 8, 4650 + b43_nphy_run_samples(dev, (b43_is_40mhz(dev) ? 40 : 20) * 8, 4650 4651 0xFFFF, 0, true, false); 4651 4652 else 4652 4653 error = b43_nphy_tx_tone(dev, freq, 250, true, false);