Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

usb: xhci: Add error handling in xhci_map_urb_for_dma

Currently xhci_map_urb_for_dma() creates a temporary buffer and copies
the SG list to the new linear buffer. But if the kzalloc_node() fails,
then the following sg_pcopy_to_buffer() can lead to crash since it
tries to memcpy to NULL pointer.

So return -ENOMEM if kzalloc returns null pointer.

Cc: stable@vger.kernel.org # 5.11
Fixes: 2017a1e58472 ("usb: xhci: Use temporary buffer to consolidate SG")
Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20240229141438.619372-10-mathias.nyman@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Prashanth K and committed by
Greg Kroah-Hartman
be95cc6d fb18e5bb

+2
+2
drivers/usb/host/xhci.c
··· 1219 1219 1220 1220 temp = kzalloc_node(buf_len, GFP_ATOMIC, 1221 1221 dev_to_node(hcd->self.sysdev)); 1222 + if (!temp) 1223 + return -ENOMEM; 1222 1224 1223 1225 if (usb_urb_dir_out(urb)) 1224 1226 sg_pcopy_to_buffer(urb->sg, urb->num_sgs,