Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

memory: omap-gpmc: Fix unselectable debug option for GPMC

Commit 63aa945b1013 ("memory: omap-gpmc: Add Kconfig option for debug")
added a debug option for GPMC, but somehow managed to keep it unselectable.

This probably happened because I had some uncommitted changes and the
GPMC option is selected in the platform specific Kconfig.

Let's also update the description a bit, it does not mention that
enabling the debug option also disables the reset of GPMC controller
during the init as pointed out by Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> and Roger Quadros <rogerq@ti.com>.

Fixes: 63aa945b1013 ("memory: omap-gpmc: Add Kconfig option for debug")
Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>

+9 -3
+9 -3
drivers/memory/Kconfig
··· 58 58 memory drives like NOR, NAND, OneNAND, SRAM. 59 59 60 60 config OMAP_GPMC_DEBUG 61 - bool 61 + bool "Enable GPMC debug output and skip reset of GPMC during init" 62 62 depends on OMAP_GPMC 63 63 help 64 64 Enables verbose debugging mostly to decode the bootloader provided 65 - timings. Enable this during development to configure devices 66 - connected to the GPMC bus. 65 + timings. To preserve the bootloader provided timings, the reset 66 + of GPMC is skipped during init. Enable this during development to 67 + configure devices connected to the GPMC bus. 68 + 69 + NOTE: In addition to matching the register setup with the bootloader 70 + you also need to match the GPMC FCLK frequency used by the 71 + bootloader or else the GPMC timings won't be identical with the 72 + bootloader timings. 67 73 68 74 config MVEBU_DEVBUS 69 75 bool "Marvell EBU Device Bus Controller"