Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/arm: make undeclared items static

Make the following items static to avoid clashes with
other parts of the kernel (dev_attr_core_id) or just
silence the following sparse warning:

drivers/gpu/drm/arm/malidp_drv.c:371:24: warning: symbol 'malidp_fb_create' was not declared. Should it be static?
drivers/gpu/drm/arm/malidp_drv.c:494:6: warning: symbol 'malidp_error_stats_dump' was not declared. Should it be static?
drivers/gpu/drm/arm/malidp_drv.c:668:1: warning: symbol 'dev_attr_core_id' was not declared. Should it be static?

Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191017111756.12861-1-ben.dooks@codethink.co.uk

authored by

Ben Dooks (Codethink) and committed by
Liviu Dudau
be428f24 e30b38b7

+5 -5
+5 -5
drivers/gpu/drm/arm/malidp_drv.c
··· 368 368 return false; 369 369 } 370 370 371 - struct drm_framebuffer * 371 + static struct drm_framebuffer * 372 372 malidp_fb_create(struct drm_device *dev, struct drm_file *file, 373 373 const struct drm_mode_fb_cmd2 *mode_cmd) 374 374 { ··· 491 491 spin_unlock_irqrestore(&malidp->errors_lock, irqflags); 492 492 } 493 493 494 - void malidp_error_stats_dump(const char *prefix, 495 - struct malidp_error_stats error_stats, 496 - struct seq_file *m) 494 + static void malidp_error_stats_dump(const char *prefix, 495 + struct malidp_error_stats error_stats, 496 + struct seq_file *m) 497 497 { 498 498 seq_printf(m, "[%s] num_errors : %d\n", prefix, 499 499 error_stats.num_errors); ··· 665 665 return snprintf(buf, PAGE_SIZE, "%08x\n", malidp->core_id); 666 666 } 667 667 668 - DEVICE_ATTR_RO(core_id); 668 + static DEVICE_ATTR_RO(core_id); 669 669 670 670 static int malidp_init_sysfs(struct device *dev) 671 671 {