Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

rtc: r7301: Replace spin_lock_irqsave with spin_lock in hard IRQ

It is redundant to do irqsave and irqrestore in hardIRQ context, where
it has been in a irq-disabled context.

Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/1612355981-6764-4-git-send-email-tanxiaofei@huawei.com

authored by

Xiaofei Tan and committed by
Alexandre Belloni
be3df3f8 51317975

+2 -3
+2 -3
drivers/rtc/rtc-r7301.c
··· 320 320 { 321 321 struct rtc_device *rtc = dev_id; 322 322 struct rtc7301_priv *priv = dev_get_drvdata(rtc->dev.parent); 323 - unsigned long flags; 324 323 irqreturn_t ret = IRQ_NONE; 325 324 u8 alrm_ctrl; 326 325 327 - spin_lock_irqsave(&priv->lock, flags); 326 + spin_lock(&priv->lock); 328 327 329 328 rtc7301_select_bank(priv, 1); 330 329 ··· 334 335 rtc_update_irq(rtc, 1, RTC_IRQF | RTC_AF); 335 336 } 336 337 337 - spin_unlock_irqrestore(&priv->lock, flags); 338 + spin_unlock(&priv->lock); 338 339 339 340 return ret; 340 341 }