Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

smb: client: remove redudant assignment in cifs_strict_fsync()

Remove redudant assignment of @rc as it will be overwritten by the
following cifs_file_flush() call.

Reported-by: Steve French <stfrench@microsoft.com>
Addresses-Coverity: 1665925
Fixes: 210627b0aca9 ("smb: client: fix missing timestamp updates with O_TRUNC")
Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.org>
Cc: linux-cifs@vger.kernel.org
Signed-off-by: Steve French <stfrench@microsoft.com>

authored by

Paulo Alcantara and committed by
Steve French
be3898a3 dba9f997

+4 -9
+4 -9
fs/smb/client/file.c
··· 2754 2754 struct cifsFileInfo *smbfile = file->private_data; 2755 2755 struct inode *inode = file_inode(file); 2756 2756 unsigned int xid; 2757 - int rc = 0; 2757 + int rc; 2758 2758 2759 2759 rc = file_write_and_wait_range(file, start, end); 2760 2760 if (rc) { ··· 2762 2762 return rc; 2763 2763 } 2764 2764 2765 - xid = get_xid(); 2766 - 2767 - cifs_dbg(FYI, "Sync file - name: %pD datasync: 0x%x\n", 2768 - file, datasync); 2765 + cifs_dbg(FYI, "%s: name=%pD datasync=0x%x\n", __func__, file, datasync); 2769 2766 2770 2767 if (!CIFS_CACHE_READ(CIFS_I(inode))) { 2771 2768 rc = cifs_zap_mapping(inode); 2772 - if (rc) { 2773 - cifs_dbg(FYI, "rc: %d during invalidate phase\n", rc); 2774 - rc = 0; /* don't care about it in fsync */ 2775 - } 2769 + cifs_dbg(FYI, "%s: invalidate mapping: rc = %d\n", __func__, rc); 2776 2770 } 2777 2771 2772 + xid = get_xid(); 2778 2773 rc = cifs_file_flush(xid, inode, smbfile); 2779 2774 free_xid(xid); 2780 2775 return rc;