Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/ast: astdp: fix loop timeout check

This code has an issue because it loops until "i" is set to UINT_MAX but
the test for failure assumes that "i" is set to zero. The result is that
it will only print an error message if we succeed on the very last try.
Reformat the loop to count forwards instead of backwards.

Fixes: 2281475168d2 ("drm/ast: astdp: Perform link training during atomic_enable")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/1ba8da25-2d09-4924-a4ff-c0714bfbb192@stanley.mountain

authored by

Dan Carpenter and committed by
Thomas Zimmermann
be280fdd b7ecc44a

+8 -7
+8 -7
drivers/gpu/drm/ast/ast_dp.c
··· 146 146 void ast_dp_link_training(struct ast_device *ast) 147 147 { 148 148 struct drm_device *dev = &ast->base; 149 - unsigned int i = 10; 149 + int i; 150 150 151 - while (i--) { 152 - u8 vgacrdc = ast_get_index_reg(ast, AST_IO_VGACRI, 0xdc); 151 + for (i = 0; i < 10; i++) { 152 + u8 vgacrdc; 153 153 154 - if (vgacrdc & AST_IO_VGACRDC_LINK_SUCCESS) 155 - break; 156 154 if (i) 157 155 msleep(100); 156 + 157 + vgacrdc = ast_get_index_reg(ast, AST_IO_VGACRI, 0xdc); 158 + if (vgacrdc & AST_IO_VGACRDC_LINK_SUCCESS) 159 + return; 158 160 } 159 - if (!i) 160 - drm_err(dev, "Link training failed\n"); 161 + drm_err(dev, "Link training failed\n"); 161 162 } 162 163 163 164 void ast_dp_set_on_off(struct drm_device *dev, bool on)