tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

scsi: bfa: Use zeroing allocator rather than allocator/memset

Use vzalloc instead of vmalloc followed by memset 0.

Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci

Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Acked-by: Anil Gurumurthy <anil.gurumurthy@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Himanshu Jha and committed by
Martin K. Petersen bde70f3c 05583121

+3 -8
+1 -2
drivers/scsi/bfa/bfad.c
··· 610 610 /* Iterate through the KVA meminfo queue */ 611 611 list_for_each(km_qe, &kva_info->qe) { 612 612 kva_elem = (struct bfa_mem_kva_s *) km_qe; 613 - kva_elem->kva = vmalloc(kva_elem->mem_len); 613 + kva_elem->kva = vzalloc(kva_elem->mem_len); 614 614 if (kva_elem->kva == NULL) { 615 615 bfad_hal_mem_release(bfad); 616 616 rc = BFA_STATUS_ENOMEM; 617 617 goto ext; 618 618 } 619 - memset(kva_elem->kva, 0, kva_elem->mem_len); 620 619 } 621 620 622 621 /* Iterate through the DMA meminfo queue */
+2 -6
drivers/scsi/bfa/bfad_debugfs.c
··· 81 81 82 82 fw_debug->buffer_len = sizeof(struct bfa_trc_mod_s); 83 83 84 - fw_debug->debug_buffer = vmalloc(fw_debug->buffer_len); 84 + fw_debug->debug_buffer = vzalloc(fw_debug->buffer_len); 85 85 if (!fw_debug->debug_buffer) { 86 86 kfree(fw_debug); 87 87 printk(KERN_INFO "bfad[%d]: Failed to allocate fwtrc buffer\n", 88 88 bfad->inst_no); 89 89 return -ENOMEM; 90 90 } 91 - 92 - memset(fw_debug->debug_buffer, 0, fw_debug->buffer_len); 93 91 94 92 spin_lock_irqsave(&bfad->bfad_lock, flags); 95 93 rc = bfa_ioc_debug_fwtrc(&bfad->bfa.ioc, ··· 123 125 124 126 fw_debug->buffer_len = sizeof(struct bfa_trc_mod_s); 125 127 126 - fw_debug->debug_buffer = vmalloc(fw_debug->buffer_len); 128 + fw_debug->debug_buffer = vzalloc(fw_debug->buffer_len); 127 129 if (!fw_debug->debug_buffer) { 128 130 kfree(fw_debug); 129 131 printk(KERN_INFO "bfad[%d]: Failed to allocate fwsave buffer\n", 130 132 bfad->inst_no); 131 133 return -ENOMEM; 132 134 } 133 - 134 - memset(fw_debug->debug_buffer, 0, fw_debug->buffer_len); 135 135 136 136 spin_lock_irqsave(&bfad->bfad_lock, flags); 137 137 rc = bfa_ioc_debug_fwsave(&bfad->bfa.ioc,