perf/core: Fix ctx_event_type in ctx_resched()

In ctx_resched(), EVENT_FLEXIBLE should be sched_out when EVENT_PINNED is
added. However, ctx_resched() calculates ctx_event_type before checking
this condition. As a result, pinned events will NOT get higher priority
than flexible events.

The following shows this issue on an Intel CPU (where ref-cycles can
only use one hardware counter).

1. First start:
perf stat -C 0 -e ref-cycles -I 1000
2. Then, in the second console, run:
perf stat -C 0 -e ref-cycles:D -I 1000

The second perf uses pinned events, which is expected to have higher
priority. However, because it failed in ctx_resched(). It is never
run.

This patch fixes this by calculating ctx_event_type after re-evaluating
event_type.

Reported-by: Ephraim Park <ephiepark@fb.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: <jolsa@redhat.com>
Cc: <kernel-team@fb.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Fixes: 487f05e18aa4 ("perf/core: Optimize event rescheduling on active contexts")
Link: http://lkml.kernel.org/r/20180306055504.3283731-1-songliubraving@fb.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>

authored by Song Liu and committed by Ingo Molnar bd903afe 629ae2ee

Changed files
+3 -1
kernel
events
+3 -1
kernel/events/core.c
··· 2246 2246 struct perf_event_context *task_ctx, 2247 2247 enum event_type_t event_type) 2248 2248 { 2249 - enum event_type_t ctx_event_type = event_type & EVENT_ALL; 2249 + enum event_type_t ctx_event_type; 2250 2250 bool cpu_event = !!(event_type & EVENT_CPU); 2251 2251 2252 2252 /* ··· 2255 2255 */ 2256 2256 if (event_type & EVENT_PINNED) 2257 2257 event_type |= EVENT_FLEXIBLE; 2258 + 2259 + ctx_event_type = event_type & EVENT_ALL; 2258 2260 2259 2261 perf_pmu_disable(cpuctx->ctx.pmu); 2260 2262 if (task_ctx)