Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

cpuidle: Drop misleading comments about RCU usage

The commit 1098582a0f6c ("sched,idle,rcu: Push rcu_idle deeper into the
idle path"), moved the calls rcu_idle_enter|exit() into the cpuidle core.

However, it forgot to remove a couple of comments in enter_s2idle_proper()
about why RCU_NONIDLE earlier was needed. So, let's drop them as they have
become a bit misleading.

Fixes: 1098582a0f6c ("sched,idle,rcu: Push rcu_idle deeper into the idle path")
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

authored by

Ulf Hansson and committed by
Rafael J. Wysocki
bd805274 36050d89

-10
-10
drivers/cpuidle/cpuidle.c
··· 142 142 143 143 time_start = ns_to_ktime(local_clock()); 144 144 145 - /* 146 - * trace_suspend_resume() called by tick_freeze() for the last CPU 147 - * executing it contains RCU usage regarded as invalid in the idle 148 - * context, so tell RCU about that. 149 - */ 150 145 tick_freeze(); 151 146 /* 152 147 * The state used here cannot be a "coupled" one, because the "coupled" ··· 154 159 target_state->enter_s2idle(dev, drv, index); 155 160 if (WARN_ON_ONCE(!irqs_disabled())) 156 161 local_irq_disable(); 157 - /* 158 - * timekeeping_resume() that will be called by tick_unfreeze() for the 159 - * first CPU executing it calls functions containing RCU read-side 160 - * critical sections, so tell RCU about that. 161 - */ 162 162 if (!(target_state->flags & CPUIDLE_FLAG_RCU_IDLE)) 163 163 rcu_idle_exit(); 164 164 tick_unfreeze();