Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: ll_temac: Use devm_platform_ioremap_resource_byname()

platform_get_resource() may fail and return NULL, so we had better
check its return value to avoid a NULL pointer dereference a bit later
in the code. Fix it to use devm_platform_ioremap_resource_byname()
instead of calling platform_get_resource_byname() and devm_ioremap().

Fixes: 8425c41d1ef7 ("net: ll_temac: Extend support to non-device-tree platforms")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Wang Hai and committed by
David S. Miller
bd69058f 3ce38d39

+2 -4
+2 -4
drivers/net/ethernet/xilinx/ll_temac_main.c
··· 1407 1407 } 1408 1408 1409 1409 /* map device registers */ 1410 - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); 1411 - lp->regs = devm_ioremap(&pdev->dev, res->start, 1412 - resource_size(res)); 1413 - if (!lp->regs) { 1410 + lp->regs = devm_platform_ioremap_resource_byname(pdev, 0); 1411 + if (IS_ERR(lp->regs)) { 1414 1412 dev_err(&pdev->dev, "could not map TEMAC registers\n"); 1415 1413 return -ENOMEM; 1416 1414 }