Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Input: lifebook - use "static inline" instead of "inline" in lifebook.h

For functions defined in header files we should use static inline rather
than inline, which breaks under the latest upstream gcc (which is really
gcc issue, but static inline is better suited regardless).

The related error (with allmodconfig under tile):

MODPOST 4002 modules
ERROR: "lifebook_detect" [drivers/input/mouse/psmouse.ko] undefined!

Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

authored by

Chen Gang and committed by
Dmitry Torokhov
bd447b61 02b6a58b

+3 -3
+3 -3
drivers/input/mouse/lifebook.h
··· 16 16 int lifebook_detect(struct psmouse *psmouse, bool set_properties); 17 17 int lifebook_init(struct psmouse *psmouse); 18 18 #else 19 - inline void lifebook_module_init(void) 19 + static inline void lifebook_module_init(void) 20 20 { 21 21 } 22 - inline int lifebook_detect(struct psmouse *psmouse, bool set_properties) 22 + static inline int lifebook_detect(struct psmouse *psmouse, bool set_properties) 23 23 { 24 24 return -ENOSYS; 25 25 } 26 - inline int lifebook_init(struct psmouse *psmouse) 26 + static inline int lifebook_init(struct psmouse *psmouse) 27 27 { 28 28 return -ENOSYS; 29 29 }