Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/tegra: dsi - Remove unneeded code

A bunch of registers are initialized to 0 upon during driver probe. It
turns out that none of these are actually needed, so they can simply be
dropped.

Signed-off-by: Thierry Reding <treding@nvidia.com>

-85
-85
drivers/gpu/drm/tegra/dsi.c
··· 644 644 { 645 645 struct tegra_drm *tegra = dev_get_drvdata(client->parent); 646 646 struct tegra_dsi *dsi = host1x_client_to_dsi(client); 647 - unsigned long value, i; 648 647 int err; 649 648 650 649 dsi->output.type = TEGRA_OUTPUT_DSI; ··· 662 663 dev_err(dsi->dev, "debugfs setup failed: %d\n", err); 663 664 } 664 665 665 - /* 666 - * enable high-speed mode, checksum generation, ECC generation and 667 - * disable raw mode 668 - */ 669 - value = tegra_dsi_readl(dsi, DSI_HOST_CONTROL); 670 - value |= DSI_HOST_CONTROL_ECC | DSI_HOST_CONTROL_CS | 671 - DSI_HOST_CONTROL_HS; 672 - value &= ~DSI_HOST_CONTROL_RAW; 673 - tegra_dsi_writel(dsi, value, DSI_HOST_CONTROL); 674 - 675 - tegra_dsi_writel(dsi, 0, DSI_SOL_DELAY); 676 - tegra_dsi_writel(dsi, 0, DSI_MAX_THRESHOLD); 677 - 678 - tegra_dsi_writel(dsi, 0, DSI_INIT_SEQ_CONTROL); 679 - 680 - for (i = 0; i < 8; i++) { 681 - tegra_dsi_writel(dsi, 0, DSI_INIT_SEQ_DATA_0 + i); 682 - tegra_dsi_writel(dsi, 0, DSI_INIT_SEQ_DATA_8 + i); 683 - } 684 - 685 - for (i = 0; i < 12; i++) 686 - tegra_dsi_writel(dsi, 0, DSI_PKT_SEQ_0_LO + i); 687 - 688 - tegra_dsi_writel(dsi, 0, DSI_DCS_CMDS); 689 - 690 666 err = tegra_dsi_pad_calibrate(dsi); 691 667 if (err < 0) { 692 668 dev_err(dsi->dev, "MIPI calibration failed: %d\n", err); 693 669 return err; 694 670 } 695 - 696 - tegra_dsi_writel(dsi, DSI_POWER_CONTROL_ENABLE, DSI_POWER_CONTROL); 697 - usleep_range(300, 1000); 698 671 699 672 return 0; 700 673 } ··· 716 745 return err; 717 746 718 747 return 0; 719 - } 720 - 721 - static void tegra_dsi_initialize(struct tegra_dsi *dsi) 722 - { 723 - unsigned int i; 724 - 725 - tegra_dsi_writel(dsi, 0, DSI_POWER_CONTROL); 726 - 727 - tegra_dsi_writel(dsi, 0, DSI_INT_ENABLE); 728 - tegra_dsi_writel(dsi, 0, DSI_INT_STATUS); 729 - tegra_dsi_writel(dsi, 0, DSI_INT_MASK); 730 - 731 - tegra_dsi_writel(dsi, 0, DSI_HOST_CONTROL); 732 - tegra_dsi_writel(dsi, 0, DSI_CONTROL); 733 - 734 - tegra_dsi_writel(dsi, 0, DSI_SOL_DELAY); 735 - tegra_dsi_writel(dsi, 0, DSI_MAX_THRESHOLD); 736 - 737 - tegra_dsi_writel(dsi, 0, DSI_INIT_SEQ_CONTROL); 738 - 739 - for (i = 0; i < 8; i++) { 740 - tegra_dsi_writel(dsi, 0, DSI_INIT_SEQ_DATA_0 + i); 741 - tegra_dsi_writel(dsi, 0, DSI_INIT_SEQ_DATA_8 + i); 742 - } 743 - 744 - for (i = 0; i < 12; i++) 745 - tegra_dsi_writel(dsi, 0, DSI_PKT_SEQ_0_LO + i); 746 - 747 - tegra_dsi_writel(dsi, 0, DSI_DCS_CMDS); 748 - 749 - for (i = 0; i < 4; i++) 750 - tegra_dsi_writel(dsi, 0, DSI_PKT_LEN_0_1 + i); 751 - 752 - tegra_dsi_writel(dsi, 0x00000000, DSI_PHY_TIMING_0); 753 - tegra_dsi_writel(dsi, 0x00000000, DSI_PHY_TIMING_1); 754 - tegra_dsi_writel(dsi, 0x000000ff, DSI_PHY_TIMING_2); 755 - tegra_dsi_writel(dsi, 0x00000000, DSI_BTA_TIMING); 756 - 757 - tegra_dsi_writel(dsi, 0, DSI_TIMEOUT_0); 758 - tegra_dsi_writel(dsi, 0, DSI_TIMEOUT_1); 759 - tegra_dsi_writel(dsi, 0, DSI_TO_TALLY); 760 - 761 - tegra_dsi_writel(dsi, 0, DSI_PAD_CONTROL_0); 762 - tegra_dsi_writel(dsi, 0, DSI_PAD_CONTROL_CD); 763 - tegra_dsi_writel(dsi, 0, DSI_PAD_CD_STATUS); 764 - tegra_dsi_writel(dsi, 0, DSI_VIDEO_MODE_CONTROL); 765 - tegra_dsi_writel(dsi, 0, DSI_PAD_CONTROL_1); 766 - tegra_dsi_writel(dsi, 0, DSI_PAD_CONTROL_2); 767 - tegra_dsi_writel(dsi, 0, DSI_PAD_CONTROL_3); 768 - tegra_dsi_writel(dsi, 0, DSI_PAD_CONTROL_4); 769 - 770 - tegra_dsi_writel(dsi, 0, DSI_GANGED_MODE_CONTROL); 771 - tegra_dsi_writel(dsi, 0, DSI_GANGED_MODE_START); 772 - tegra_dsi_writel(dsi, 0, DSI_GANGED_MODE_SIZE); 773 748 } 774 749 775 750 static int tegra_dsi_host_attach(struct mipi_dsi_host *host, ··· 831 914 dsi->regs = devm_ioremap_resource(&pdev->dev, regs); 832 915 if (IS_ERR(dsi->regs)) 833 916 return PTR_ERR(dsi->regs); 834 - 835 - tegra_dsi_initialize(dsi); 836 917 837 918 dsi->mipi = tegra_mipi_request(&pdev->dev); 838 919 if (IS_ERR(dsi->mipi))