Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

pps: generators: tio: fix platform_set_drvdata()

platform_set_drvdata() is setting a double pointer to struct pps_tio as
driver_data, which will point to the local stack of probe function instead
of intended data. Set driver_data correctly and fix illegal memory access
by its user.

BUG: unable to handle page fault for address: ffffc9000117b738
RIP: 0010:hrtimer_active+0x2b/0x60
Call Trace:
? hrtimer_active+0x2b/0x60
hrtimer_cancel+0x19/0x50
pps_gen_tio_remove+0x1e/0x80 [pps_gen_tio]

Fixes: c89755d1111f ("pps: generators: Add PPS Generator TIO Driver")
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Acked-by: Rodolfo Giometti <giometti@enneenne.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20250318114038.2058677-1-raag.jadav@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Raag Jadav and committed by
Greg Kroah-Hartman
bcfb4435 7c7f1bfd

+1 -1
+1 -1
drivers/pps/generators/pps_gen_tio.c
··· 230 230 hrtimer_setup(&tio->timer, hrtimer_callback, CLOCK_REALTIME, 231 231 HRTIMER_MODE_ABS); 232 232 spin_lock_init(&tio->lock); 233 - platform_set_drvdata(pdev, &tio); 233 + platform_set_drvdata(pdev, tio); 234 234 235 235 return 0; 236 236 }