Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fbdev: viafb: fix typo in hw_bitblt_1 and hw_bitblt_2

There are some actions with value 'tmp' but 'dst_addr' is checked instead.
It is obvious that a copy-paste error was made here and the value
of variable 'tmp' should be checked here.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Aleksandr Burakov <a.burakov@rosalinux.ru>
Signed-off-by: Helge Deller <deller@gmx.de>

authored by

Aleksandr Burakov and committed by
Helge Deller
bc87bb34 97419172

+2 -2
+2 -2
drivers/video/fbdev/via/accel.c
··· 115 115 116 116 if (op != VIA_BITBLT_FILL) { 117 117 tmp = src_mem ? 0 : src_addr; 118 - if (dst_addr & 0xE0000007) { 118 + if (tmp & 0xE0000007) { 119 119 printk(KERN_WARNING "hw_bitblt_1: Unsupported source " 120 120 "address %X\n", tmp); 121 121 return -EINVAL; ··· 260 260 writel(tmp, engine + 0x18); 261 261 262 262 tmp = src_mem ? 0 : src_addr; 263 - if (dst_addr & 0xE0000007) { 263 + if (tmp & 0xE0000007) { 264 264 printk(KERN_WARNING "hw_bitblt_2: Unsupported source " 265 265 "address %X\n", tmp); 266 266 return -EINVAL;