tjh.dev
Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
net: x25: Use list_for_each_entry() to simplify code in x25_route.c
Convert list_for_each() to list_for_each_entry() where
applicable. This simplifies the code.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
authored by
Wang Hai
and committed by
David S. Miller
bc831fac
9e2b7b04
+3
-12
+3
-12
net/x25/x25_route.c
+3
-12
net/x25/x25_route.c
···
27
27
struct net_device *dev)
28
28
{
29
29
struct x25_route *rt;
30
-
struct list_head *entry;
31
30
int rc = -EINVAL;
32
31
33
32
write_lock_bh(&x25_route_list_lock);
34
33
35
-
list_for_each(entry, &x25_route_list) {
36
-
rt = list_entry(entry, struct x25_route, node);
37
-
34
+
list_for_each_entry(rt, &x25_route_list, node) {
38
35
if (!memcmp(&rt->address, address, sigdigits) &&
39
36
rt->sigdigits == sigdigits)
40
37
goto out;
···
75
78
struct net_device *dev)
76
79
{
77
80
struct x25_route *rt;
78
-
struct list_head *entry;
79
81
int rc = -EINVAL;
80
82
81
83
write_lock_bh(&x25_route_list_lock);
82
84
83
-
list_for_each(entry, &x25_route_list) {
84
-
rt = list_entry(entry, struct x25_route, node);
85
-
85
+
list_for_each_entry(rt, &x25_route_list, node) {
86
86
if (!memcmp(&rt->address, address, sigdigits) &&
87
87
rt->sigdigits == sigdigits && rt->dev == dev) {
88
88
__x25_remove_route(rt);
···
135
141
struct x25_route *x25_get_route(struct x25_address *addr)
136
142
{
137
143
struct x25_route *rt, *use = NULL;
138
-
struct list_head *entry;
139
144
140
145
read_lock_bh(&x25_route_list_lock);
141
146
142
-
list_for_each(entry, &x25_route_list) {
143
-
rt = list_entry(entry, struct x25_route, node);
144
-
147
+
list_for_each_entry(rt, &x25_route_list, node) {
145
148
if (!memcmp(&rt->address, addr, rt->sigdigits)) {
146
149
if (!use)
147
150
use = rt;