Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: ufs: core: Refactor ufshcd_hba_enable()

Use "if error return" style in ufshcd_hba_enable(). No functional change.

Cc: Bart Van Assche <bvanassche@acm.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Keoseong Park <keosung.park@samsung.com>
Link: https://lore.kernel.org/r/20221028073553epcms2p6dc4f8bdbebdc8f96f43fc4197b3edd0c@epcms2p6
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Keoseong Park and committed by
Martin K. Petersen
bc77fb9c e6629dcb

+11 -7
+11 -7
drivers/ufs/core/ufshcd.c
··· 4668 4668 /* enable UIC related interrupts */ 4669 4669 ufshcd_enable_intr(hba, UFSHCD_UIC_MASK); 4670 4670 ret = ufshcd_dme_reset(hba); 4671 - if (!ret) { 4672 - ret = ufshcd_dme_enable(hba); 4673 - if (!ret) 4674 - ufshcd_vops_hce_enable_notify(hba, POST_CHANGE); 4675 - if (ret) 4676 - dev_err(hba->dev, 4677 - "Host controller enable failed with non-hce\n"); 4671 + if (ret) { 4672 + dev_err(hba->dev, "DME_RESET failed\n"); 4673 + return ret; 4678 4674 } 4675 + 4676 + ret = ufshcd_dme_enable(hba); 4677 + if (ret) { 4678 + dev_err(hba->dev, "Enabling DME failed\n"); 4679 + return ret; 4680 + } 4681 + 4682 + ufshcd_vops_hce_enable_notify(hba, POST_CHANGE); 4679 4683 } else { 4680 4684 ret = ufshcd_hba_execute_hce(hba); 4681 4685 }