Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

hwmon: (aspeed-pwm-tacho) Avoid possible buffer overflow

aspeed_create_fan() reads a pwm_port value using of_property_read_u32().
If pwm_port will be more than ARRAY_SIZE(pwm_port_params), there will be
a buffer overflow in
aspeed_create_pwm_port()->aspeed_set_pwm_port_enable(). The patch fixes
the potential buffer overflow.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
Link: https://lore.kernel.org/r/20200703111518.9644-1-novikov@ispras.ru
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

authored by

Evgeny Novikov and committed by
Guenter Roeck
bc4071aa dcb7fd82

+2
+2
drivers/hwmon/aspeed-pwm-tacho.c
··· 851 851 ret = of_property_read_u32(child, "reg", &pwm_port); 852 852 if (ret) 853 853 return ret; 854 + if (pwm_port >= ARRAY_SIZE(pwm_port_params)) 855 + return -EINVAL; 854 856 aspeed_create_pwm_port(priv, (u8)pwm_port); 855 857 856 858 ret = of_property_count_u8_elems(child, "cooling-levels");