Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

PCI: cpcihp: Add missing curly braces in cpci_configure_slot()

I don't have this hardware but it looks like we weren't adding bridge
devices as intended. Maybe the bridge is always the last device?

Fixes: 05b125004815 ("PCI: cpcihp: Iterate over all devices in slot, not functions 0-7")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Yijing Wang <wangyijing@huawei.com>
CC: stable@vger.kernel.org # v3.9+

authored by

Dan Carpenter and committed by
Bjorn Helgaas
bc3b5b47 a1b7f2f6

+2 -1
+2 -1
drivers/pci/hotplug/cpci_hotplug_pci.c
··· 286 286 } 287 287 parent = slot->dev->bus; 288 288 289 - list_for_each_entry(dev, &parent->devices, bus_list) 289 + list_for_each_entry(dev, &parent->devices, bus_list) { 290 290 if (PCI_SLOT(dev->devfn) != PCI_SLOT(slot->devfn)) 291 291 continue; 292 292 if (pci_is_bridge(dev)) 293 293 pci_hp_add_bridge(dev); 294 + } 294 295 295 296 296 297 pci_assign_unassigned_bridge_resources(parent->self);