Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

md: protect against crash upon fsync on ro array

If an fsync occurs on a read-only array, we need to send a
completion for the IO and may not increment the active IO count.
Otherwise, we hit a bug trace and can't stop the MD array anymore.

By advice of Christoph Hellwig we return success upon a flush
request but we return -EROFS for other writes.
We detect flush requests by checking if the bio has zero sectors.

This patch is suitable to any -stable kernel to which it applies.

Cc: Christoph Hellwig <hch@infradead.org>
Cc: Ben Hutchings <ben@decadent.org.uk>
Cc: NeilBrown <neilb@suse.de>
Cc: stable@vger.kernel.org
Signed-off-by: Sebastian Riemer <sebastian.riemer@profitbricks.com>
Reported-by: Ben Hutchings <ben@decadent.org.uk>
Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
Signed-off-by: NeilBrown <neilb@suse.de>

authored by

Sebastian Riemer and committed by
NeilBrown
bbfa57c0 19f949f5

+4
+4
drivers/md/md.c
··· 307 307 bio_io_error(bio); 308 308 return; 309 309 } 310 + if (mddev->ro == 1 && unlikely(rw == WRITE)) { 311 + bio_endio(bio, bio_sectors(bio) == 0 ? 0 : -EROFS); 312 + return; 313 + } 310 314 smp_rmb(); /* Ensure implications of 'active' are visible */ 311 315 rcu_read_lock(); 312 316 if (mddev->suspended) {