Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

HID: thingm: remove not needed error message

LED core takes care of handling failed calls to thingm_let_set.
- print error message in set_brightness_delayed or
- pass error to caller in led_set_brightness_sync
Also the error message here doesn't provide any hint what actually
went wrong. Therefore remove it.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@rehat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

authored by

Heiner Kallweit and committed by
Jiri Kosina
bbf4ac9c a4362fd6

+1 -6
+1 -6
drivers/hid/hid-thingm.c
··· 148 148 enum led_brightness brightness) 149 149 { 150 150 struct thingm_led *led = container_of(ldev, struct thingm_led, ldev); 151 - int ret; 152 151 153 - ret = thingm_write_color(led->rgb); 154 - if (ret) 155 - hid_err(led->rgb->tdev->hdev, "failed to write color\n"); 156 - 157 - return ret; 152 + return thingm_write_color(led->rgb); 158 153 } 159 154 160 155 static int thingm_init_led(struct thingm_led *led, const char *color_name,