Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork

Configure Feed

Select the types of activity you want to include in your feed.

serial: 8250: Reinit port_id when adding back serial8250_isa_devs

After fixing the serial core port device to use port->port_id instead of
port->line, unloading a hardware specific 8250 port driver started
producing an error for "sysfs: cannot create duplicate filename".

This is happening as we are wrongly initializing port->port_id to zero
when adding back serial8250_isa_devs instances, and the serial8250:0.0
sysfs entry may already exist. For serial8250 devices, we typically have
multiple devices mapped to a single driver instance. For the
serial8250_isa_devs instances, the port->port_id is the same as port->line.

Let's fix the issue by re-initializing port_id when adding back the
serial8250_isa_devs instances in serial8250_unregister_port().

Fixes: d962de6ae51f ("serial: core: Fix serial core port id to not use port->line")
Signed-off-by: Tony Lindgren <tony@atomide.com>
Link: https://lore.kernel.org/r/20230804123546.25293-1-tony@atomide.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Tony Lindgren and committed by
Greg Kroah-Hartman
bbb4abb1 6be1a8d5

+1
+1
drivers/tty/serial/8250/8250_core.c
··· 1204 1204 uart->port.flags &= ~UPF_BOOT_AUTOCONF; 1205 1205 uart->port.type = PORT_UNKNOWN; 1206 1206 uart->port.dev = &serial8250_isa_devs->dev; 1207 + uart->port.port_id = line; 1207 1208 uart->capabilities = 0; 1208 1209 serial8250_init_port(uart); 1209 1210 serial8250_apply_quirks(uart);