Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

usbmon: fix tiny race exposed by the fastboot patches

usbmon registers the notifier chain, takes the bus lock and then goes to
scan the existing devices for hooking up.

Unfortunately, if usb_mon gets initialized while USB bus discovery is
going on, it's possible that usbmon gets a notifier on one cpu (which runs
without USB locks), and the scan is going on and also finds the new bus,
resulting in a double sysfs registration, which then produces a WARNING.

Pete Zaitcev did the bug diagnostics on this one

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Acked-by: Pete Zaitcev <zaitcev@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

authored by

Arjan van de Ven and committed by
Greg Kroah-Hartman
bb4e3b5a 8520f380

+1 -1
+1 -1
drivers/usb/mon/mon_main.c
··· 361 361 } 362 362 // MOD_INC_USE_COUNT(which_module?); 363 363 364 - usb_register_notify(&mon_nb); 365 364 366 365 mutex_lock(&usb_bus_list_lock); 367 366 list_for_each_entry (ubus, &usb_bus_list, bus_list) { 368 367 mon_bus_init(ubus); 369 368 } 369 + usb_register_notify(&mon_nb); 370 370 mutex_unlock(&usb_bus_list_lock); 371 371 return 0; 372 372