Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

mac80211: fix SSID copy on IBSS JOIN

The 'ssid' field of the cfg80211_ibss_params is a u8 pointer and
its length is likely to be less than IEEE80211_MAX_SSID_LEN most
of the time.

This patch fixes the ssid copy in ieee80211_ibss_join() by using
the SSID length to prevent it from reading beyond the string.

Cc: stable@vger.kernel.org
Signed-off-by: Antonio Quartulli <ordex@autistici.org>
[rewrapped commit message, small rewording]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

authored by

Antonio Quartulli and committed by
Johannes Berg
badecb00 f7fbf70e

+1 -1
+1 -1
net/mac80211/ibss.c
··· 1108 1108 sdata->u.ibss.state = IEEE80211_IBSS_MLME_SEARCH; 1109 1109 sdata->u.ibss.ibss_join_req = jiffies; 1110 1110 1111 - memcpy(sdata->u.ibss.ssid, params->ssid, IEEE80211_MAX_SSID_LEN); 1111 + memcpy(sdata->u.ibss.ssid, params->ssid, params->ssid_len); 1112 1112 sdata->u.ibss.ssid_len = params->ssid_len; 1113 1113 1114 1114 mutex_unlock(&sdata->u.ibss.mtx);