Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

coccinelle: api/atomic_as_refcounter: include message type in output

A common practice is to grep for "WARNING" or "ERROR" text in the report
output from a Coccinelle semantic patch script. So, include the text
"WARNING: " in the report output generated by the semantic patch for
desired filtering of the output. Also improves the readability of the
output. Here is an example of the old and new outputs reported:

xyz_file.c:131:39-40: atomic_add_unless
xyz_file.c:131:39-40: WARNING: atomic_add_unless

xyz_file.c:196:6-25: atomic_dec_and_test variation before object free at line 208.
xyz_file.c:196:6-25: WARNING: atomic_dec_and_test variation before object free at line 208.

Signed-off-by: Deepak R Varma <drv@mailo.com>
Acked-by: Julia Lawall <Julia.Lawall@inria.fr>

authored by

Deepak R Varma and committed by
Julia Lawall
bab55037 1b929c02

+4 -4
+4 -4
scripts/coccinelle/api/atomic_as_refcounter.cocci
··· 55 55 p1 << r1.p1; 56 56 p2 << r1.p2; 57 57 @@ 58 - msg = "atomic_dec_and_test variation before object free at line %s." 58 + msg = "WARNING: atomic_dec_and_test variation before object free at line %s." 59 59 coccilib.report.print_report(p1[0], msg % (p2[0].line)) 60 60 61 61 @r4 exists@ ··· 88 88 p1 << r4.p1; 89 89 p2 << r4.p2; 90 90 @@ 91 - msg = "atomic_dec_and_test variation before object free at line %s." 91 + msg = "WARNING: atomic_dec_and_test variation before object free at line %s." 92 92 coccilib.report.print_report(p1[0], msg % (p2[0].line)) 93 93 94 94 @r2 exists@ ··· 107 107 @script:python depends on report@ 108 108 p1 << r2.p1; 109 109 @@ 110 - msg = "atomic_add_unless" 110 + msg = "WARNING: atomic_add_unless" 111 111 coccilib.report.print_report(p1[0], msg) 112 112 113 113 @r3 exists@ ··· 126 126 @script:python depends on report@ 127 127 p1 << r3.p1; 128 128 @@ 129 - msg = "x = atomic_add_return(-1, ...)" 129 + msg = "WARNING: x = atomic_add_return(-1, ...)" 130 130 coccilib.report.print_report(p1[0], msg)