Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

HID: elan: Remove elan_mute_led_get_brigtness()

The led_classdev already contains a cached value of the last set
brightness, the brightness_get callback is only meant for LED drivers
which can read back the actual / current brightness from the hardware.

Since elan_mute_led_get_brigtness() just returns the last set value
it does not add any functionality, so we can just remove it.

Reviewed-by: Marek Behún <kabel@kernel.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

authored by

Hans de Goede and committed by
Jiri Kosina
ba3f9293 2601371e

-10
-10
drivers/hid/hid-elan.c
··· 410 410 return 0; 411 411 } 412 412 413 - static enum led_brightness elan_mute_led_get_brigtness(struct led_classdev *led_cdev) 414 - { 415 - struct device *dev = led_cdev->dev->parent; 416 - struct hid_device *hdev = to_hid_device(dev); 417 - struct elan_drvdata *drvdata = hid_get_drvdata(hdev); 418 - 419 - return drvdata->mute_led_state; 420 - } 421 - 422 413 static int elan_mute_led_set_brigtness(struct led_classdev *led_cdev, 423 414 enum led_brightness value) 424 415 { ··· 452 461 453 462 mute_led->name = "elan:red:mute"; 454 463 mute_led->default_trigger = "audio-mute"; 455 - mute_led->brightness_get = elan_mute_led_get_brigtness; 456 464 mute_led->brightness_set_blocking = elan_mute_led_set_brigtness; 457 465 mute_led->max_brightness = LED_ON; 458 466 mute_led->flags = LED_HW_PLUGGABLE;