Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dm zoned: dynamically allocate the dm-zoned-meta shrinker

In preparation for implementing lockless slab shrink, use new APIs to
dynamically allocate the dm-zoned-meta shrinker, so that it can be freed
asynchronously via RCU. Then it doesn't need to wait for RCU read-side
critical section when releasing the struct dmz_metadata.

Link: https://lkml.kernel.org/r/20230911094444.68966-25-zhengqi.arch@bytedance.com
Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Cc: Alasdair Kergon <agk@redhat.com>
Cc: Mike Snitzer <snitzer@kernel.org>
Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Cc: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Anna Schumaker <anna@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Bob Peterson <rpeterso@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Carlos Llamas <cmllamas@google.com>
Cc: Chandan Babu R <chandan.babu@oracle.com>
Cc: Chao Yu <chao@kernel.org>
Cc: Chris Mason <clm@fb.com>
Cc: Christian Brauner <brauner@kernel.org>
Cc: Christian Koenig <christian.koenig@amd.com>
Cc: Chuck Lever <cel@kernel.org>
Cc: Coly Li <colyli@suse.de>
Cc: Dai Ngo <Dai.Ngo@oracle.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: "Darrick J. Wong" <djwong@kernel.org>
Cc: Dave Chinner <david@fromorbit.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: David Airlie <airlied@gmail.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: David Sterba <dsterba@suse.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Gao Xiang <hsiangkao@linux.alibaba.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Huang Rui <ray.huang@amd.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Jason Wang <jasowang@redhat.com>
Cc: Jeff Layton <jlayton@kernel.org>
Cc: Jeffle Xu <jefflexu@linux.alibaba.com>
Cc: Joel Fernandes (Google) <joel@joelfernandes.org>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Josef Bacik <josef@toxicpanda.com>
Cc: Juergen Gross <jgross@suse.com>
Cc: Kent Overstreet <kent.overstreet@gmail.com>
Cc: Kirill Tkhai <tkhai@ya.ru>
Cc: Marijn Suijten <marijn.suijten@somainline.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Muchun Song <muchun.song@linux.dev>
Cc: Nadav Amit <namit@vmware.com>
Cc: Neil Brown <neilb@suse.de>
Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Cc: Olga Kornievskaia <kolga@netapp.com>
Cc: Paul E. McKenney <paulmck@kernel.org>
Cc: Richard Weinberger <richard@nod.at>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Roman Gushchin <roman.gushchin@linux.dev>
Cc: Sean Paul <sean@poorly.run>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Song Liu <song@kernel.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Steven Price <steven.price@arm.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: Tom Talpey <tom@talpey.com>
Cc: Trond Myklebust <trond.myklebust@hammerspace.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: Yue Hu <huyue2@coolpad.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Qi Zheng and committed by
Andrew Morton
ba3d6aca 1f1d459c

+16 -12
+16 -12
drivers/md/dm-zoned-metadata.c
··· 187 187 struct rb_root mblk_rbtree; 188 188 struct list_head mblk_lru_list; 189 189 struct list_head mblk_dirty_list; 190 - struct shrinker mblk_shrinker; 190 + struct shrinker *mblk_shrinker; 191 191 192 192 /* Zone allocation management */ 193 193 struct mutex map_lock; ··· 615 615 static unsigned long dmz_mblock_shrinker_count(struct shrinker *shrink, 616 616 struct shrink_control *sc) 617 617 { 618 - struct dmz_metadata *zmd = container_of(shrink, struct dmz_metadata, mblk_shrinker); 618 + struct dmz_metadata *zmd = shrink->private_data; 619 619 620 620 return atomic_read(&zmd->nr_mblks); 621 621 } ··· 626 626 static unsigned long dmz_mblock_shrinker_scan(struct shrinker *shrink, 627 627 struct shrink_control *sc) 628 628 { 629 - struct dmz_metadata *zmd = container_of(shrink, struct dmz_metadata, mblk_shrinker); 629 + struct dmz_metadata *zmd = shrink->private_data; 630 630 unsigned long count; 631 631 632 632 spin_lock(&zmd->mblk_lock); ··· 2936 2936 */ 2937 2937 zmd->min_nr_mblks = 2 + zmd->nr_map_blocks + zmd->zone_nr_bitmap_blocks * 16; 2938 2938 zmd->max_nr_mblks = zmd->min_nr_mblks + 512; 2939 - zmd->mblk_shrinker.count_objects = dmz_mblock_shrinker_count; 2940 - zmd->mblk_shrinker.scan_objects = dmz_mblock_shrinker_scan; 2941 - zmd->mblk_shrinker.seeks = DEFAULT_SEEKS; 2942 2939 2943 2940 /* Metadata cache shrinker */ 2944 - ret = register_shrinker(&zmd->mblk_shrinker, "dm-zoned-meta:(%u:%u)", 2945 - MAJOR(dev->bdev->bd_dev), 2946 - MINOR(dev->bdev->bd_dev)); 2947 - if (ret) { 2948 - dmz_zmd_err(zmd, "Register metadata cache shrinker failed"); 2941 + zmd->mblk_shrinker = shrinker_alloc(0, "dm-zoned-meta:(%u:%u)", 2942 + MAJOR(dev->bdev->bd_dev), 2943 + MINOR(dev->bdev->bd_dev)); 2944 + if (!zmd->mblk_shrinker) { 2945 + ret = -ENOMEM; 2946 + dmz_zmd_err(zmd, "Allocate metadata cache shrinker failed"); 2949 2947 goto err; 2950 2948 } 2949 + 2950 + zmd->mblk_shrinker->count_objects = dmz_mblock_shrinker_count; 2951 + zmd->mblk_shrinker->scan_objects = dmz_mblock_shrinker_scan; 2952 + zmd->mblk_shrinker->private_data = zmd; 2953 + 2954 + shrinker_register(zmd->mblk_shrinker); 2951 2955 2952 2956 dmz_zmd_info(zmd, "DM-Zoned metadata version %d", zmd->sb_version); 2953 2957 for (i = 0; i < zmd->nr_devs; i++) ··· 2999 2995 */ 3000 2996 void dmz_dtr_metadata(struct dmz_metadata *zmd) 3001 2997 { 3002 - unregister_shrinker(&zmd->mblk_shrinker); 2998 + shrinker_free(zmd->mblk_shrinker); 3003 2999 dmz_cleanup_metadata(zmd); 3004 3000 kfree(zmd); 3005 3001 }