Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: usb: sr9700: Replace mdelay() with msleep() in sr9700_bind()

sr9700_bind() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Jia-Ju Bai and committed by
David S. Miller
ba23dc64 6dff5add

+1 -1
+1 -1
drivers/net/usb/sr9700.c
··· 358 358 /* power up and reset phy */ 359 359 sr_write_reg(dev, SR_PRR, PRR_PHY_RST); 360 360 /* at least 10ms, here 20ms for safe */ 361 - mdelay(20); 361 + msleep(20); 362 362 sr_write_reg(dev, SR_PRR, 0); 363 363 /* at least 1ms, here 2ms for reading right register */ 364 364 udelay(2 * 1000);